New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1513798:  Null pointer dereferences  (REVERSE_INULL)
/reportdesign/source/ui/dlg/Navigator.cxx: 586 in rptui::NavigatorTree::_propertyChanged(const com::sun::star::beans::PropertyChangeEvent &)()


________________________________________________________________________________________________________
*** CID 1513798:  Null pointer dereferences  (REVERSE_INULL)
/reportdesign/source/ui/dlg/Navigator.cxx: 586 in rptui::NavigatorTree::_propertyChanged(const com::sun::star::beans::PropertyChangeEvent &)()
580         }
581         else if ( _rEvent.PropertyName == PROPERTY_PAGEFOOTERON )
582             traverseSection(xReport->getPageFooter(),xParent.get(), RID_SVXBMP_PAGEHEADERFOOTER);
583         else if ( _rEvent.PropertyName == PROPERTY_REPORTFOOTERON )
584         {
585             int nPos = -1;
>>>     CID 1513798:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "xParent" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
586             if (xReport->getPageFooterOn() && xParent)
587                 nPos = m_xTreeView->iter_n_children(*xParent) - 1;
588             traverseSection(xReport->getReportFooter(),xParent.get(),RID_SVXBMP_REPORTHEADERFOOTER,nPos);
589         }
590     }
591     

** CID 1513797:  SpotBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
/xmerge/source/xmerge/java/org/openoffice/xmerge/util/ActiveSyncDriver.java: 128 in org.openoffice.xmerge.util.ActiveSyncDriver.Convert(java.lang.String, java.lang.String, java.lang.String, java.lang.String)()


________________________________________________________________________________________________________
*** CID 1513797:  SpotBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
/xmerge/source/xmerge/java/org/openoffice/xmerge/util/ActiveSyncDriver.java: 128 in org.openoffice.xmerge.util.ActiveSyncDriver.Convert(java.lang.String, java.lang.String, java.lang.String, java.lang.String)()
122                     doc.write(fos);
123                     fos.flush();
124                 } finally {
125                     if (fos != null)
126                         fos.close();
127                 }
>>>     CID 1513797:  SpotBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
>>>     Catching RuntimeExceptions, perhaps unintentionally, with a catch block for Exception.
128             } catch (Exception e) {
129                 bOK = false;
130             } finally {
131                 if (fis != null)
132                     fis.close();
133             }
134     
135             return bOK;
136         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DlCf3_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiFx7D1kmHrbxwxfJZHljjhGJwUHGGarkbXUxFYJ2-2FulhiBnQE5OiaLWDI2kPGBGUOPZYoEweTRbEIq1x9txiAsZmm3W17yoiH98lI8hD6qWRl8mM4YvUt9OJxDX2KwgozK7sWX8q5ql7LFiVUhQWkBYfo-2BfWnHj2qq8UYfMo1KHw-3D