New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1541186:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in writerperfect::WPXSvInputStream::seek(long)()


________________________________________________________________________________________________________
*** CID 1541186:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 456 in writerperfect::WPXSvInputStream::seek(long)()
450     int WPXSvInputStream::seek(tools::Long offset)
451     {
452         if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
453             return -1;
454     
455         const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>>     CID 1541186:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "tmpPosition > 9223372036854775807L" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
456         if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
457             return -1;
458     
459         try
460         {
461             mxSeekable->seek(offset);

** CID 1541185:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in writerperfect::WPXSvInputStream::tellImpl()()


________________________________________________________________________________________________________
*** CID 1541185:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/writerperfect/source/common/WPXSvInputStream.cxx: 444 in writerperfect::WPXSvInputStream::tellImpl()()
438     {
439         if ((mnLength == 0) || !mxStream.is() || !mxSeekable.is())
440             return -1;
441         else
442         {
443             const sal_Int64 tmpPosition = mxSeekable->getPosition();
>>>     CID 1541185:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "tmpPosition > 9223372036854775807L" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
444             if ((tmpPosition < 0) || (tmpPosition > LONG_MAX))
445                 return -1;
446             return static_cast<tools::Long>(tmpPosition);
447         }
448     }
449     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D1gxC_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiXV5MJlq0SQHeh3zIHStjN-2BM9Vbq8-2BCQyJ5qJeZmkQEdJ-2Fd2zGqzmFnHDxcKeLI7gZzhLCheJe6UfAzovCx-2BlO7zf4lGZmZ49MIjLZXoEbg3PoDbLKORPqe3kDofnlraSqqd3IKby1EbJzpwAr3qX0RcBSW20CtadQzHn0Oiv6EY-3D