ESC meeting minutes: 2023-12-14
Miklos Vajna
vmiklos at collabora.com
Mon Dec 18 07:30:33 UTC 2023
* Present:
+ Heiko, Caolan, Cloph, Hossein, Olivier, Ilmari, Michael S, Michael W, Stephan, Thorsten, Xisco, Miklos, Eike, Justin
* Completed Action Items:
+ Update Stephan’s affiliation at https://www.documentfoundation.org/engineering-sc/ (Ilmari)
+ enable Android builds for libreoffice-7-6 Jenkins builds (Cloph)
- almost done, will do it later today
+ contact Gwyn about the security list (Stephan)
+ next step: apply for officesecurity@ membership
+ Caolan is an admin there, will get notification
* Pending Action Items:
* Release Engineering update (Cloph)
+ 7.6: 7.6.5 RC1 in 7 weeks?
+ 24.2: RC 1 next week (UI freeze)
+ beta1 is tagged, branch is created
+ late features (Michael S)
+ working on the new ODF encryption
+ want to get rid of some obsolete checkboxes
+ also an extern library (argon2) for a better KDF function
+ assume it's already packaged in ~all existing distros
+ if you need string changes after RC1, ping us (Cloph)
+ late features (Samuel M / Thorsten)
+ improve UX (and avoid traps for users) around macro security settings
+ fixes tdf#158576
+ patchset: https://gerrit.libreoffice.org/c/core/+/160751 (and relationship
chain)
+ small enough, and fits the bill hopefully, with overall security
improvements?
+ goal is to have it as a much less confusing setup (Thorsten)
+ any objections?
+ none (all)
* Documentation (Olivier)
+ Helpcontents2
+ Continuing updates on Menus (ohallot)
+ New page on Help offline (R. Lima)
+ Guides
+ Work in progress for 24.2 guides
+ Bugzilla Documentation statistics
274(274) bugs open
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
created 5(1) 13(2) 42(-4) 265(-3)
commented 10(4) 35(0) 107(-35) 941(-33)
resolved 3(2) 4(1) 14(-1) 138(-3)
+ top 10 contributors:
Stéphane Guillou made 26 changes in 1 month, and 337 changes in 1 year
Jérôme made 14 changes in 1 month, and 23 changes in 1 year
Kaganski, Mike made 11 changes in 1 month, and 77 changes in 1 year
Heiko Tietze made 8 changes in 1 month, and 105 changes in 1 year
Caolán McNamara made 4 changes in 1 month, and 4 changes in 1 year
m.a.riosv made 4 changes in 1 month, and 11 changes in 1 year
Raal made 4 changes in 1 month, and 6 changes in 1 year
Seth Chaiklin made 4 changes in 1 month, and 320 changes in 1 year
Werner Tietz made 4 changes in 1 month, and 4 changes in 1 year
Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 1 year
* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
253(253) (topicUI) bugs open, 46(46) (needsUXEval) needs to be evaluated by the UXteam
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
added 6(1) 13(1) 16(0) 29(0)
commented 111(28) 294(84) 543(53) 2255(66)
removed 0(-1) 1(0) 3(0) 15(0)
resolved 7(-6) 28(3) 78(-3) 334(1)
+ top 10 contributors:
Heiko Tietze made 149 changes in 1 month, and 1335 changes in 1 year
Stéphane Guillou made 107 changes in 1 month, and 624 changes in 1 year
ady made 33 changes in 1 month, and 133 changes in 1 year
Dieter made 30 changes in 1 month, and 233 changes in 1 year
Vernon, Stuart Foote made 24 changes in 1 month, and 308 changes in 1 year
Ilmari Lauhakangas made 20 changes in 1 month, and 226 changes in 1 year
Seth Chaiklin made 16 changes in 1 month, and 81 changes in 1 year
Rafael Lima made 15 changes in 1 month, and 119 changes in 1 year
Eyal Rozenberg made 12 changes in 1 month, and 218 changes in 1 year
Matt K made 11 changes in 1 month, and 17 changes in 1 year
+ [Bug 158439] Design: UI Inconsistency in "Target in Document" dialog to define
a hyperlink
-> + [Bug 158685] Implement a simple calculation of values to input size and
position of draw objects
+ [Bug 106316] New sidebar deck for comments
+ [Bug 158657] Revamp the online update dialog
+ [Bug 158533] Incorrectly export number 0 form calc to PDF
+ [Bug 158647] add a 'comments reviewing' pane
-> + [Bug 158628] pressing backspace on list with empty paragraph moves the text
to previous item or out of the list
+ [Bug 130278] Line spacing "Fixed" not setable if the odt comes from doc
+ [Bug 158601] Page direction not the same as sheet direction
+ [Bug 158588] Redesign font embedding options in sfx2/.../documentfontspage.ui
-> + [Bug 158587] Improve column/row highlighting in Calc
+ kudos to Sahil Gautam
+ like it :-) (Caolan)
* Crash Testing (Caolan)
+ 25(+1) import failure, 3(+0) export failures
+ 735 coverity issues
- down from thousands, to hundreds :-)
+ 3 ossfuzz issues
- 2 timeouts, 1 OOM
* Crash Reporting (Xisco)
+ 7.5.8.2 2618(+564)
+ 7.5.9.2 112(+0)
+ 7.6.1.2 10294(+365)
+ 7.6.2.1 30731(+2648)
+ 7.6.3.2 2930(+1073)
+ 7.6.4.1 709(+0)
Regressions in 7.6:
+ https://crashreport.libreoffice.org/stats/signature/static%20bool%20cppu::idefaultConstructElements(struct%20_sal_Sequence%20*%20*,%20struct%20_typelib_TypeDescriptionReference%20*,%20long,%20long,%20long)
+ probably related to multi-color gradients
+ https://crashreport.libreoffice.org/stats/signature/static%20SwUndoId%20lcl_GetSwUndoId(const%20class%20SwFrameFormat%20*)
* Mentoring (Hossein)
* Finalized and publish a blog post
+ How to set-up an IDE for Python
+ How to get auto-completion via REPL / ptpython in interactive console
LibreOffice extensions with Python – part 2: Debugging
https://dev.blog.documentfoundation.org/2023/12/14/libreoffice-extensions-with-python-part-2-debugging/
+ VolunteerMatch project for Java -> Python porting
+ Received help offer from 2 new volunteers
+ Had a discussion with a volunteer
+ His patch is finalized
committer... 1 week 1 month 3 months 12 months
open 62(-11) 137(3) 137(-35) 137(-35)
reviews 326(-56) 1332(12) 2950(20) 11698(0)
merged 250(-48) 1087(-49) 2893(36) 12233(67)
abandoned 38(27) 103(29) 186(19) 627(20)
own commits 180(-61) 835(-84) 2343(8) 9741(-13)
review commits 57(-13) 237(6) 658(9) 2953(0)
contributor... 1 week 1 month 3 months 12 months
open 177(-18) 258(-11) 260(-16) 261(-16)
reviews 796(-50) 2910(-90) 7312(60) 30698(-158)
merged 30(17) 76(-12) 389(8) 2516(-87)
abandoned 13(10) 57(8) 116(10) 620(0)
own commits 21(6) 70(6) 208(7) 1007(5)
review commits 0(0) 0(0) 0(0) 0(0)
+ easyHack statistics:
needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 318(318)
total 408(408) assigned 23(23) open 357(357)
+ top 10 contributors:
Armin Le Grand (allotropia) made 10 patches in 1 month, and 65 patches in 1 year
Matt K made 5 patches in 1 month, and 12 patches in 1 year
Sahil Gautam made 5 patches in 1 month, and 5 patches in 1 year
Dr. David Alan Gilbert made 5 patches in 1 month, and 23 patches in 1 year
Stéphane Guillou made 4 patches in 1 month, and 43 patches in 1 year
Sahil Gautam made 3 patches in 1 month, and 18 patches in 1 year
Srebotnjak, Martin made 2 patches in 1 month, and 12 patches in 1 year
Weblate made 2 patches in 1 month, and 4 patches in 1 year
Amin Irgaliev made 1 patches in 1 month, and 4 patches in 1 year
Martin Gube made 1 patches in 1 month, and 3 patches in 1 year
+ top 10 reviewers:
Vajna, Miklos made 152 review comments in 1 month, and 1002 in 1 year
Nabet, Julien made 104 review comments in 1 month, and 1014 in 1 year
Caolán McNamara made 104 review comments in 1 month, and 848 in 1 year
Xisco Fauli made 102 review comments in 1 month, and 834 in 1 year
Thorsten Behrens made 80 review comments in 1 month, and 544 in 1 year
Kaganski, Mike made 78 review comments in 1 month, and 408 in 1 year
Ilmari Lauhakangas made 64 review comments in 1 month, and 396 in 1 year
Hossein made 60 review comments in 1 month, and 274 in 1 year
Michael Stahl made 60 review comments in 1 month, and 1122 in 1 year
Grandin, Noel made 54 review comments in 1 month, and 592 in 1 year
+ Patches automatically abandoned:
+ Checked with the list of commiters (Hossein)
https://gerrit.libreoffice.org/admin/groups/70c36bd1bfcbef2d3bcfc25622e8aaf57d99bb7c,members
postgresql: upgrade to release 15.2 ( Taichi Haradaguchi ) -> commiter
- https://gerrit.libreoffice.org/#/c/149080
Change Skia/Raster to enabled by default ( Roman Kuznetsov ) -> commiter
- https://gerrit.libreoffice.org/#/c/154322
filter: XHTML export: Making half a dozen class style names unique ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154727
filter: XHTML export: Fixing image horizontal alignment with ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154728
filter: XHTML export: Adding z-index to HTML/CSS output ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154729
filter: XHTML export: Adding margin of list to HTML/CSS ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154730
filter: XHTML export: Adding alignment='middle' to images <img> ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154731
filter: XHTML export: Adding columns by styles ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154732
filter: XHTML export: Adding multiplier for min-height and ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154733
filter: XHTML export: tdf95662 - removed duplication of list ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154734
filter: XHTML export: Fixing previous regression of duplication ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154735
filter: XHTML export: ListLevel had been wrong incremented in ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154736
tdf95662: filter: XHTML export: Complex-Multi-List-Level testODT: ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154737
tdf95662 filter: XHTML export: Enabling <text:tabs> also for the ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154738
tdf95662 filter: XHTML export: Enabling @left:margin for list label ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154739
filter: XHTML export: Fixing style:family prefix for unique style ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154740
filter: XHTML export: Adding basic ODF Draw to SVG functionality ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154741
filter: XHTML export: Using now CSS vertical-align instead of image ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154742
filter: XHTML export: 1) A frame nested as character will be no ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154840
filter: XHTML export: Regression of heading number due to previous ... ( Michael Stahl ) -> commiter
- https://gerrit.libreoffice.org/#/c/154841
tdf#105298: Improve font names and styles on macOS ( خالد حسني ) -> commiter
- https://gerrit.libreoffice.org/#/c/155455
tdf#156672: Make sure layout mode is always correctly set ( خالد حسني ) -> commiter
- https://gerrit.libreoffice.org/#/c/155515
tdf#134193: Make the math edit window follow the direction of the document ( خالد حسني ) -> commiter
- https://gerrit.libreoffice.org/#/c/155667
Simplify long if statements ( Hannah Meeks ) -> Restored, needs some work
- https://gerrit.libreoffice.org/#/c/155868
tdf#156345 Enhancement to aid making page selections ( Jim Raykowski ) -> commiter
- https://gerrit.libreoffice.org/#/c/155933
tdf#156776 Base Table Design Save As For Dummies... ( Pierre Vacher ) -> Restored
- https://gerrit.libreoffice.org/#/c/155950
tdf#156719: use unique accelerator for Insert > Signature Line ( Stéphane Guillou ) -> Restored by the author
- https://gerrit.libreoffice.org/#/c/156276
tdf#156973 Exclude the number style name property from indicating ( Jim Raykowski ) -> commiter
- https://gerrit.libreoffice.org/#/c/156366
Ensure BarOfPie has ScaleData::ShiftedCategoryPosition == false ( Kurt Nordback ) -> Restored, merge conflict
- https://gerrit.libreoffice.org/#/c/156367
Restructuring to support reasonably code-efficient design for of-pie charts ( Kurt Nordback ) -> Restored, build problems
- https://gerrit.libreoffice.org/#/c/156460
tdf#45904: Remove old SwXFootnote Java tests ( Dipam Turkar ) -> Restored, needs some work
- https://gerrit.libreoffice.org/#/c/156512
Mulit-color gradient UI ( Heiko Tietze ) -> commiter
- https://gerrit.libreoffice.org/#/c/157182
Some rejiggering of of-pie code, plus implementing subpie chart ( Kurt Nordback ) -> Restored, merge conflict
- https://gerrit.libreoffice.org/#/c/157302
WIP tdf#156965 ( خالد حسني ) -> commiter
- https://gerrit.libreoffice.org/#/c/157375
tdf#157342 Master Document Navigator: Disable Delete menu item when ( Jim Raykowski ) -> commiter
- https://gerrit.libreoffice.org/#/c/157599
vcl: add ImplLayoutArgs::GetMissingCodes() ( Chris Sherlock ) -> Marked work as in progress
- https://gerrit.libreoffice.org/#/c/157692
tdf#156717 Added correct version to PDF metadata ( Adlair Cerecedo-Mendez ) -> EasyHack, author not active anymore
- https://gerrit.libreoffice.org/#/c/157841
tdf#109085: allow correct shutdown when user logs off on Windows ( Mike Kaganski ) -> commiter
- https://gerrit.libreoffice.org/#/c/39884
MM dialogs: Load styles from shell, rather than temp doc ( Michael Weghorn ) -> commiter
- https://gerrit.libreoffice.org/#/c/81093
tdf#97318 MM: Avoid page styles with data from other records ( Michael Weghorn ) -> commiter
- https://gerrit.libreoffice.org/#/c/81095
+ big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
Kira Tubo
Dev Lo lodev at ossii.com.tw
* Outreachy (Ilmari)
+ work has started
+ we encouraged both students to post weekly reports to the dev list (Heiko)
+ qt6 port, including welding
+ quick find sidebar deck, replacing the old findbar
+ https://www.outreachy.org/alums/2023-12/
* Commit Access
* Developer Certification (Stephan/Miklos/Thorsten/László)
+ resting since: 10 weeks (limit: 20 weeks)
* Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 206 ok: 186 ko: 17 fail ratio: 8.25% mean_ok: 8 ( 10) median_ok: 5 ( 7)
gerrit_android_arm jobs: 206 ok: 180 ko: 22 fail ratio: 10.68% mean_ok: 9 ( 10) median_ok: 6 ( 7)
gerrit_android_x86 jobs: 204 ok: 182 ko: 17 fail ratio: 8.33% mean_ok: 8 ( 10) median_ok: 6 ( 7)
gerrit_android_x86_64 jobs: 207 ok: 180 ko: 22 fail ratio: 10.63% mean_ok: 7 ( 9) median_ok: 5 ( 7)
gerrit_linux_clang_dbgutil jobs: 415 ok: 326 ko: 62 fail ratio: 14.94% mean_ok: 37 ( 38) median_ok: 34 ( 35)
gerrit_linux_gcc_release jobs: 480 ok: 391 ko: 65 fail ratio: 13.54% mean_ok: 15 ( 16) median_ok: 13 ( 14)
gerrit_mac jobs: 423 ok: 346 ko: 48 fail ratio: 11.35% mean_ok: 47 ( 47) median_ok: 43 ( 43)
gerrit_windows jobs: 441 ok: 293 ko: 95 fail ratio: 21.54% mean_ok: 74 (134) median_ok: 73 (101)
gerrit_master_ml jobs: 519 ok: 247 ko: 194 fail ratio: 37.38% mean_ok: 151 (151) median_ok: 125 (126)
gerrit_master jobs: 57 ok: 27 ko: 28 fail ratio: 49.12% mean_ok: 139 (144) median_ok: 150 (150)
gerrit_master_seq jobs: 459 ok: 220 ko: 163 fail ratio: 35.51% mean_ok: 150 (151) median_ok: 125 (125)
+ https://dev-www.libreoffice.org/tmp/gerrit_231214.html
+ tests that failed more than twice in last seven days
3 CppunitTest_sw_mailmerge gerrit_windows
3 CppunitTest_sw_uiwriter3 gerrit_windows
3 UITest_autofilter gerrit_linux_clang_dbgutil
4 CppunitTest_sw_ooxmlexport17 gerrit_mac
4 CppunitTest_test_a11y gerrit_windows
6 CppunitTest_sd_export_tests-ooxml2 gerrit_windows
- Caused by only one not merged patch(Xisco)
9 Killed by the kill-wrapper gerrit_linux_clang_dbgutil
27 aborted by jenkins job timeout gerrit_windows
+ this week: windows timeout are getting better (Cloph)
+ mostly last week, but not sure what got fixed
+ these hangs, are these dbgutil builds? (Caolan)
+ was hoping it's a dbgutil build where a hang is meant to be an abort
+ yes (Cloph)
+ some failures are caused by translation updates went wrong, now fixed.
* What’s cooking (Miklos)
+ Multi-page floating tables in Writer, see tdf#158081 for details (Miklos)
+ A11y update (Michael W)
+ tdf#123864, implement reporting of "checkable" a11y state
+ improving the state of toolbar buttons reporting
+ Android (Michael W)
+ now available in Weblate for translation, thanks cloph!
+ build-time lint checks enabled
+ Import of Word drawing canvas (Regina)
+ ODF Package encryption (Michael S, see above)
+ Authenticated encryption with associated data (AEAD) means there is a hash(equivalent) to verify the data and we can have additional data next to some IV
* QA update (Xisco)
+ UNCONFIRMED: 1038 (+17)
+ enhancements: 240 (+5)
+ needsUXEval: 6 (+1)
+ haveBackTrace: 12 (+0)
+ needsDevAdvice: 36 (-1)
+ documentation: 3 (+0)
+ android: 0 (+0)
+ iOS: 0 (+0)
+ Online: 10 (+0)
+ Most pressing bugs:
New:
None
Old:
+ Plain text copied to clipboard and pasted to CSV is not saved.
+ https://bugs.documentfoundation.org/show_bug.cgi?id=154339
+ bisected to Szymon, Xisco has a proposed partial revert
Fixed:
+ New high severity bugs of the week:
+ Objects anchored to cell are not duplicated when copy-pasting to range larger than source (comment 16)
+ https://bugs.documentfoundation.org/show_bug.cgi?id=121443
+ bisected to Kohei
+ Improve shortcut key list for German keyboard layout
+ https://bugs.documentfoundation.org/show_bug.cgi?id=82117
+ not tagged as a regression
- Turn into an EasyHack (Xisco)
* QA stats (Stéphane)
+ https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
+118 +11 (-113) overall)
many thanks to the top bug squashers:
QA Administrators 20
Stéphane Guillou (stragu) 14
Balázs Varga (allotropia) 9
Heiko Tietze 6
m.a.riosv 6
Patrick Luby 5
Buovjaga 4
Dieter 4
Gabor Kelemen (allotropia) 4
Laurent Balland 4
+ top 10 bugs reporters:
Gabor Kelemen (allotropia) 13
Rafael Lima 7
Stéphane Guillou (stragu) 4
Jérôme 3
Regina Henschel 3
Telesto 3
Justin L 2
Samuel Mehrbrodt (allotropia) 2
Xisco Faulí 2
david.vantyghem 2
+ top 10 bugs fixers:
Balazs Varga 9
Patrick Luby 5
Balland-Poirier, Laurent 3
Grandin, Noel 2
Kelemen, Gabor 2
Nabet, Julien 2
Balázs Ágasvári 1
Caolán McNamara 1
Ilmari Lauhakangas 1
Justin Luth 1
+ top 10 bugs confirmers:
Stéphane Guillou 14
m.a.riosv 13
Balazs Varga 8
*UNKNOWN* 5
Heiko Tietze 4
Vernon, Stuart Foote 4
Nabet, Julien 3
Raal 3
Rafael Lima 3
Weghorn, Michael 3
* Bisected bugs open: keyword 'bisected'
+ more accurate - down to a single commit.
+ http://bit.ly/2dyIfDy
+
done by:
kemaldonado 2
stcasey 2
Stéphane Guillou 2
Xisco Fauli 2
Kira Tubo 1
Raal 1
Timur 1
* Bibisected bugs open: keyword 'bibisected'
+ http://bit.ly/2cSCXlS
+
done by:
kemaldonado 2
stcasey 2
Stéphane Guillou 2
Xisco Fauli 2
Ilmari Lauhakangas 1
Kira Tubo 1
Raal 1
Timur 1
* all bugs tagged with 'regression'
+ 1231(+5) bugs open of 13026(+17) total 23(+2) high prio.
done by:
Stéphane Guillou 2
Xisco Fauli 2
Bogdan B 1
Ilmari Lauhakangas 1
Raal 1
Samuel Mehrbrodt 1
stcasey 1
Telesto 1
Timur 1
* ~Component count net * high severity regressions
+ http://bit.ly/1HWHb3E
Writer - 13(-1)
Calc - 3(+0)
Impress - 2(+2)
LibreOffice - 2(+0)
Printing and PDF export - 1(+1)
UI - 1(+0)
by OS:
All - 16(+1)
Linux - 6(+2)
Mac OS X - 0(+0)
Windows - 1(+0)
* ~Component count net * all regressions
+ http://bit.ly/1BUdI8i
Writer: other - 428(-3)
Calc - 228(+3)
Impress - 132(+0)
LibreOffice - 53(+1)
Draw - 50(+0)
Crashes - 48(+2)
Writer: docx filter - 43(+0)
Base - 41(+0)
UI - 38(+0)
Borders - 36(+1)
Writer: perf - 35(+1)
Writer: other filter - 32(+1)
Printing and PDF export - 27(+1)
RTL - 25(+1)
Chart - 22(+0)
filters and storage - 21(+0)
BASIC - 18(-1)
Writer: doc filter - 16(+0)
graphics stack - 12(+0)
Formula Editor - 6(+0)
framework - 3(+0)
Extensions - 2(+0)
sdk - 2(+0)
Linguistic - 1(+0)
* Next ESC call? (Miklos)
+ skip next 2 weeks?
+ skip the 28th Dec? (Thorsten)
+ Cloph will be out
=> cancel the one on 28th Dec
=> 21th Dec will be held, Thorsten or Stephan will run it
More information about the LibreOffice
mailing list