New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1521510:  Program hangs  (ORDER_REVERSAL)


________________________________________________________________________________________________________
*** CID 1521510:  Program hangs  (ORDER_REVERSAL)
/sal/osl/unx/process.cxx: 332 in ChildStatusProc(void *)()
326                                 pChild->m_status = WEXITSTATUS(status);
327                             else if (WIFSIGNALED(status))
328                                 pChild->m_status = 128 + WTERMSIG(status);
329                             else
330                                 pChild->m_status = -1;
331     
>>>     CID 1521510:  Program hangs  (ORDER_REVERSAL)
>>>     Calling "osl_setCondition" acquires lock "std::unique_lock<std::mutex>._M_device" while holding lock "_oslMutexImpl.mutex" (count: 2 / 5).
332                             osl_setCondition(pChild->m_terminated);
333                         }
334     
335                         pChild = pChild->m_pnext;
336                     }
337     

** CID 1521509:  Control flow issues  (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 3791 in SwContentTree::TimerUpdate(Timer *)()


________________________________________________________________________________________________________
*** CID 1521509:  Control flow issues  (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 3791 in SwContentTree::TimerUpdate(Timer *)()
3785             }
3786             UpdateTracking();
3787             m_bIsIdleClear = false;
3788             m_bDocHasChanged = false;
3789             m_bViewHasChanged = false;
3790         }
>>>     CID 1521509:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "SwContentTree::State::ACTIVE == this->m_eState" inside this statement: "if (!pView && SwContentTree...".
3791         else if (!pView && State::ACTIVE == m_eState && !m_bIsIdleClear) // this block seems never to be entered
3792         {
3793             if(m_pActiveShell)
3794             {
3795                 SetActiveShell(nullptr);
3796             }

** CID 1521508:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1521508:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/uibase/app/applab.cxx: 383 in SwModule::InsertLab(SfxRequest &, bool)()
377             pSh->DoUndo();
378         }
379     
380         if( rItem.m_aWriting.indexOf( '<' ) >= 0 )
381         {
382             // Open database browser on recently used database
>>>     CID 1521508:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pSh" to "GetDBData", which dereferences it.
383             ShowDBObj( *pNewView, pSh->GetDBData() );
384         }
385     
386         if( rItem.m_bSynchron )
387         {
388             SfxDispatcher* pDisp = pViewFrame->GetDispatcher();

** CID 1521507:  Control flow issues  (DEADCODE)
/sw/source/uibase/misc/redlndlg.cxx: 258 in SwRedlineAcceptDlg::InitAuthors()()


________________________________________________________________________________________________________
*** CID 1521507:  Control flow issues  (DEADCODE)
/sw/source/uibase/misc/redlndlg.cxx: 258 in SwRedlineAcceptDlg::InitAuthors()()
252         SvxTPFilter *pFilterPage = m_xTabPagesCTRL->GetFilterPage();
253     
254         std::vector<OUString> aStrings;
255         OUString sOldAuthor(pFilterPage->GetSelectedAuthor());
256         pFilterPage->ClearAuthors();
257     
>>>     CID 1521507:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "0UL" inside this statement: "nCount = (pSh ? pSh->GetRed...".
258         SwRedlineTable::size_type nCount = pSh ? pSh->GetRedlineCount() : 0;
259     
260         m_bOnlyFormatedRedlines = true;
261         bool bIsNotFormated = false;
262     
263         // determine authors

** CID 1521506:    (ORDER_REVERSAL)


________________________________________________________________________________________________________
*** CID 1521506:    (ORDER_REVERSAL)
/sal/osl/unx/process.cxx: 734 in osl_getProcess()
728                 /* process is a child so insert into list */
729                 pProcImpl->m_pnext = pChild->m_pnext;
730                 pChild->m_pnext = pProcImpl;
731     
732                 pProcImpl->m_status = pChild->m_status;
733     
>>>     CID 1521506:    (ORDER_REVERSAL)
>>>     Calling "osl_checkCondition" acquires lock "std::unique_lock<std::mutex>._M_device" while holding lock "_oslMutexImpl.mutex" (count: 2 / 5).
734                 if (osl_checkCondition(pChild->m_terminated))
735                     osl_setCondition(pProcImpl->m_terminated);
736             }
737             else
738                 pProcImpl->m_pnext = nullptr;
739     
/sal/osl/unx/process.cxx: 735 in osl_getProcess()
729                 pProcImpl->m_pnext = pChild->m_pnext;
730                 pChild->m_pnext = pProcImpl;
731     
732                 pProcImpl->m_status = pChild->m_status;
733     
734                 if (osl_checkCondition(pChild->m_terminated))
>>>     CID 1521506:    (ORDER_REVERSAL)
>>>     Calling "osl_setCondition" acquires lock "std::unique_lock<std::mutex>._M_device" while holding lock "_oslMutexImpl.mutex" (count: 2 / 5).
735                     osl_setCondition(pProcImpl->m_terminated);
736             }
737             else
738                 pProcImpl->m_pnext = nullptr;
739     
740             osl_releaseMutex(ChildListMutex);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DZ6ug_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJixCsS6-2BnKijW6651IDIzTOafZvcYeKCFTjb5K7z-2BpSqDkMfadZONOCacLY8u1oqptdUohBoG3mf6ifLASIrCD6FrrnloP2LTIeAxZ00cx9TNtKJBSq-2BoEol8idWS7p2UrxXXDmmIy-2Bp3zmPFiWa5KaSg-2Be9MPII6n-2BCXDq6G8GTQE4z8UTnxagIi2WMyD3yAy