New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1520420:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1520420:  Null pointer dereferences  (FORWARD_NULL)
/forms/source/xforms/model_helper.hxx: 102 in xforms::SubmissionCollection::_remove(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
96         }
97     
98         virtual void _remove( const T& t ) override
99         {
100             auto pSubmission = dynamic_cast<Submission*>( t.get() );
101             OSL_ENSURE( pSubmission != nullptr, "invalid item?" );
>>>     CID 1520420:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pSubmission" to "setModel", which dereferences it.
102             pSubmission->setModel( nullptr );
103         }
104     };
105     
106     class InstanceCollection : public Collection<css::uno::Sequence<css::beans::PropertyValue> >
107     {

** CID 1520419:  Null pointer dereferences  (FORWARD_NULL)
/forms/source/xforms/model.cxx: 436 in xforms::Model::submitWithInteraction(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> &)()


________________________________________________________________________________________________________
*** CID 1520419:  Null pointer dereferences  (FORWARD_NULL)
/forms/source/xforms/model.cxx: 436 in xforms::Model::submitWithInteraction(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::task::XInteractionHandler> &)()
430                 dynamic_cast<Submission*>( mxSubmissions->getItem( sID ).get() );
431             OSL_ENSURE( pSubmission != nullptr, "no submission?" );
432             OSL_ENSURE( pSubmission->getModelImpl() == this,
433                         "wrong model" );
434     
435             // submit. All exceptions are allowed to leave.
>>>     CID 1520419:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pSubmission" to "submitWithInteraction", which dereferences it. (The dereference happens because this is a virtual function call.)
436             pSubmission->submitWithInteraction( _rxHandler );
437         }
438     }
439     
440     void Model::submit( const OUString& sID )
441     {

** CID 1520418:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1520418:  Null pointer dereferences  (FORWARD_NULL)
/forms/source/xforms/model_helper.hxx: 95 in xforms::SubmissionCollection::_insert(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &)()
89     
90     protected:
91         virtual void _insert( const T& t ) override
92         {
93             auto pSubmission = dynamic_cast<Submission*>( t.get() );
94             OSL_ENSURE( pSubmission != nullptr, "invalid item?" );
>>>     CID 1520418:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pSubmission" to "setModel", which dereferences it.
95             pSubmission->setModel( mpModel );
96         }
97     
98         virtual void _remove( const T& t ) override
99         {
100             auto pSubmission = dynamic_cast<Submission*>( t.get() );


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dv9ET_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiXlUMODph9VUaD-2BKzlrk6OjsritcycwkQuWEsr9bD0Uocusf3h2oReeQfMWmdzqVw1cQSvbh1nFghZhHLdr-2FtbGQ2e4TKk-2BQmDw56WS-2FuomiW1KHQVh7526KSdhMN8JlN2nQoUqEjU8nvR8seykHEFPsehHUmlMhbzPMe7A86hE0-3D