DFF_Prop_xyz vs. ESCHER_Prop_xyz ?

Caolán McNamara caolanm at redhat.com
Wed Jan 25 10:49:21 UTC 2023

On Tue, 2023-01-24 at 22:55 +0100, Regina Henschel wrote:
> Hi all,
> why there are both the defines DFF_Prop_xyz in msdffdef.hxx and the 
> defines ESCHER_Prop_xyz in escherex.hxx ?
> Both seems to be mainly based on the PIDs in Microsoft Office Drawing
> 97-2007 Binary Format Specification.

I don't know, but back in OpenOffice 1.0.3 the ESCHER ones were in
svx/inc/escherex.hxx and the PROP ones in svx/inc/msdffdef.hxx so it's
been like that for a long time and the original commit messages lost.
IIRC the escherex was for export and msdffdef was for import.

Hard to know at this remove if implementation of export was unaware of
the existence of the import duplication or if the code integration
process at the time would have required an undesirable multi-day delay
to make use of the defines in a header which may not have been directly
includable at the time.

More information about the LibreOffice mailing list