test failures with new fonts-crosextra-carlito

[Mike Kaganski]

On 26.06.2023 8:15, Rene Engelhard wrote:
> Hi,
> 
> Am 25.06.23 um 13:29 schrieb Rene Engelhard:
>> my beta1 (didn't try 7.5 yet) builds fail with a new verson of the 
>> fonts-crosextra-carlito fonts (used for Calibri). LibreOffice itself 
>> ships
> 
> My 7.5.4 builds needs the following in addition to  the already posted 
> (where applicable):
> 
> rene at frodo:~/Debian/Pakete/LibreOffice/libreoffice/libreoffice-7.5.4.2$ 
> diff -u sw/qa/extras/ooxmlexport/ooxmlexport14.cxx-old 
> sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
> --- sw/qa/extras/ooxmlexport/ooxmlexport14.cxx-old    2023-06-26 
> 06:30:09.119195022 +0200
> +++ sw/qa/extras/ooxmlexport/ooxmlexport14.cxx    2023-06-26 
> 06:30:18.891263759 +0200
> @@ -1346,8 +1346,7 @@
>   #if !defined(MACOSX)
>   DECLARE_OOXMLEXPORT_TEST(testTdf146346, "tdf146346.docx")
>   {
> -    // This was 2 (by bad docDefault vertical margins around tables in 
> footnotes)
> -    CPPUNIT_ASSERT_EQUAL(1, getPages());
> +    CPPUNIT_ASSERT_EQUAL(2, getPages());
>   }
>   #endif

Testing on Windows, using current master, and tdf146346.docx plus its 
variant with "Calibri" replaced with "Carlito" in word/styles.xml and 
word/fontTable.xml.

Both of them open with *two* pages in LO. When testing with version 
7.5.4.2, they open in one page both. When testing with MS Word 2016, 
they open in one page both. It is even with the *older* version of 
Carlito (1.103 Beta1, not 1.104 with the change you mentioned - but it's 
also 2 pages in master with that newer font).

So there are two issues here:

1. A regression after 7.5, making the file two-page;
2. A problem in unit test, claiming one page in master, when actually 
it's two.

-- 
Best regards,
Mike Kaganski