Sporadically failing CppunitTest_sc_vba_macro_test

[Stephan Bergmann]

On 5/11/23 09:58, Noel Grandin wrote:
> I would suspect that putting a
> 
>     Scheduler::ProcessEventsToIdle
> 
> into UnoApiTest::executeMacrowould be a good idea.

Some

> diff --git a/test/source/unoapi_test.cxx b/test/source/unoapi_test.cxx
> index e8198876537a..03d013b07762 100644
> --- a/test/source/unoapi_test.cxx
> +++ b/test/source/unoapi_test.cxx
> @@ -19,6 +19,8 @@
>  #include <sfx2/app.hxx>
>  #include <sfx2/objsh.hxx>
>  #include <unotools/mediadescriptor.hxx>
> +#include <vcl/scheduler.hxx>
> +
>  #include <utility>
>  
>  using namespace css;
> @@ -139,6 +141,8 @@ uno::Any UnoApiTest::executeMacro(const OUString& rScriptURL,
>                                                   aOutParamIndex, aOutParam);
>      CPPUNIT_ASSERT_EQUAL(ERRCODE_NONE, result);
>  
> +    Scheduler::ProcessEventsToIdle();
> +
>      return aRet;
>  }
>  

didn't make a difference,

> while make CppunitTest_sc_vba_macro_test; do :; done

still eventually failed for me with

> sc/qa/extras/vba-macro-test.cxx:499:testTdf149579::TestBody
> equality assertion failed
> - Expected: 1
> - Actual  : 5