ESC meeting minutes: 2023-11-23

Miklos Vajna vmiklos at collabora.com
Thu Nov 23 15:49:35 UTC 2023


* Present:
     + Olivier, Thosten, Michael S, Caolan, heiko, Stephane, Hossein, Michael W, Regina, Stephan, Xisco, Miklos, Ilmari

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Xisco)
     + 7.5 status: Additional 7.5.9 release (Curl https changes)

         - Announce next week

     + 7.6 status: 7.6.3 final announced today along with Android version

     - 7.6.4 RC1 on week 50 (in 3 weeks)

     + 24.2: first alpha this week.

         - Same as daily builds

         - beta1 in 2 weeks

     + Android version in the play store (Michael W)
       + in the play store now:
         https://play.google.com/store/apps/details?id=org.documentfoundation.libreoffice

* Documentation (Olivier)
     + Helpcontents2
         + More on updating UNO commands Help (ohallot)
     + Guides
         + Guides being updated
     + Introducing new people into the doc team.
     + Bugzilla Documentation statistics
         275(275) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created      6(2)    17(1)      51(-1)    275(-5)
          commented     16(11)   56(10)    156(8)     984(-41)
           resolved      1(0)     6(1)      16(-2)    145(-3)
     + top 10 contributors:
           Jérôme made 18 changes in 1 month, and 23 changes in 1 year
           Stéphane Guillou made 12 changes in 1 month, and 335 changes in 1 year
           Ilmari Lauhakangas made 11 changes in 1 month, and 123 changes in 1 year
           Kaganski, Mike made 11 changes in 1 month, and 83 changes in 1 year
           Heiko Tietze made 10 changes in 1 month, and 96 changes in 1 year
           Seth Chaiklin made 10 changes in 1 month, and 316 changes in 1 year
           Olivier Hallot made 8 changes in 1 month, and 418 changes in 1 year
           m.a.riosv made 5 changes in 1 month, and 15 changes in 1 year
           Raal made 4 changes in 1 month, and 6 changes in 1 year
           Werner Tietz made 4 changes in 1 month, and 4 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         255(255) (topicUI) bugs open, 57(57) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month    3 months   12 months
              added      5(1)     16(-2)     20(-1)      41(-1)
          commented     55(7)    199(-21)   479(10)    2230(15)
            removed      0(0)      1(-1)      3(-1)      17(0)
           resolved      3(0)     23(-8)     80(-3)     325(-4)
     + top 10 contributors:
           Heiko Tietze made 109 changes in 1 month, and 1333 changes in 1 year
           Stéphane Guillou made 104 changes in 1 month, and 601 changes in 1 year
           Vernon, Stuart Foote made 38 changes in 1 month, and 346 changes in 1 year
           Ilmari Lauhakangas made 31 changes in 1 month, and 247 changes in 1 year
           Eyal Rozenberg made 20 changes in 1 month, and 240 changes in 1 year
           Bob English made 10 changes in 1 month, and 10 changes in 1 year
           Dieter made 10 changes in 1 month, and 235 changes in 1 year
           Henschel, Regina made 8 changes in 1 month, and 41 changes in 1 year
           ady made 7 changes in 1 month, and 110 changes in 1 year
           Vajngerl, Tomaž made 7 changes in 1 month, and 10 changes in 1 year
     + [Bug 158291] The term "Field Shadings" is confusing
     + [Bug 158290] "Formattings" should be used instead of "Formats" in some cases
     + [Bug 158289] The term "Track changes" is being used ungrammatically
     + [Bug 97143] Only latest range highlighted when selecting multiple cell ranges
            using CTRL modifier (see comment 3)
     + [Bug 154057] Cell focus when creating a URL link button may be inconsistent
     + [Bug 158253] Shapes-via-Gallery is problematic & partially redundant with the
            Shapes sub-toolbars and sidebar

  -> + Silently remove multi-selection in thumbnailview (startcenter, template manager)
       + https://bugs.documentfoundation.org/show_bug.cgi?id=158084
         + as last comment of this bug
  -> + Unclear autoformat function delete space at line and paragraph start/end
       + https://bugs.documentfoundation.org/show_bug.cgi?id=139963
         - input on this is welcome

* Crash Testing (Caolan)
     + 27(-9) import failure, 3(-10) export failures
      - I believe new crash fix is in since then
     + n/a coverity issues
      - coverity is out of action for the moment
      - new version of coverity less than 50% build success
      - possibly O[U]String literals
     + 7 ossfuzz issues

     - some of the itempool leaks are closed and 3 are 'Unreproducible' so I suspect that issue is solved

     - but new itempool crash, bug filed with reproducer

       https://bugs.documentfoundation.org/show_bug.cgi?id=158317

     - 24 bytes :-)


* Crash Reporting (Xisco)
     + 7.5.8.2    935(+412)
     + 7.6.0.3    17304(+772)
     + 7.6.1.2    8993(+570)
     + 7.6.2.1    21296(+3789)

     - https://crashreport.libreoffice.org/stats/signature/BrandImage::SetDrawingArea(weld::DrawingArea%20*)

     - Regression in  7.5.7.1. 788 crashes

     - Fixed in 7.5.8.2


* Mentoring (Hossein)
+ New EasyHack (suggestion from Julien)
   tdf#158337 - Use C++20 std::erase instead of std::removed followed by erase
   https://bugs.documentfoundation.org/show_bug.cgi?id=158337
+ SDK examples improvement
   + New volunteer on VolunteerMatch for Java -> Python port of SDK examples
     + Had a call, described the goal, and the porting
   + Still working on Java -> C++ port of examples
   + Cleaned up multi-language examples and makefiles

           committer...   1 week     1 month      3 months     12 months
                   open      57(5)      159(-36)     184(-11)      184(-11)
                reviews     342(-18)   1234(-74)    3170(-66)    11578(-268)
                 merged     255(-73)   1091(-110)   2903(-189)   12071(-864)
              abandoned      18(10)      54(1)       161(2)        577(-60)
            own commits     209(-49)    904(-21)    2322(55)      9757(20)
         review commits      40(-10)    217(-9)      645(-1)      2928(-22)
         contributor...   1 week     1 month      3 months    12 months
                   open     174(36)     274(34)      291(51)      292(51)
                reviews     756(-96)   3030(-116)   7314(202)   30944(312)
                 merged      18(4)      132(70)      434(242)    2753(850)
              abandoned      16(13)      30(16)       86(21)      635(64)
            own commits       9(-8)      62(-8)      210(-4)     1013(-30)
         review commits       0(0)        0(0)         0(0)         0(0)
     + easyHack statistics:
        needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 322(322)
        total 413(413)   assigned 24(24)   open 360(360)
     + top 10 contributors:
           Sahil Gautam made 7 patches in 1 month, and 17 patches in 1 year
           Armin Le Grand (allotropia) made 5 patches in 1 month, and 60 patches in 1 year
           Omkar Acharekar  made 3 patches in 1 month, and 5 patches in 1 year
           Li Yang made 3 patches in 1 month, and 5 patches in 1 year
           Matt K made 2 patches in 1 month, and 8 patches in 1 year
           Marco Pinto made 2 patches in 1 month, and 4 patches in 1 year
           Stéphane Guillou made 2 patches in 1 month, and 39 patches in 1 year
           Ankit Kumar Jaipuriar made 2 patches in 1 month, and 7 patches in 1 year
           Montane, Joan made 1 patches in 1 month, and 3 patches in 1 year
           Tzschichholz, Rico made 1 patches in 1 month, and 4 patches in 1 year
     + top 10 reviewers:
           Caolán McNamara made 136 review comments in 1 month, and 788 in 1 year
           Vajna, Miklos made 120 review comments in 1 month, and 948 in 1 year
           Thorsten Behrens made 104 review comments in 1 month, and 530 in 1 year
           Michael Stahl made 100 review comments in 1 month, and 1166 in 1 year
           Ilmari Lauhakangas made 80 review comments in 1 month, and 426 in 1 year
           Nabet, Julien made 78 review comments in 1 month, and 972 in 1 year
           Kaganski, Mike made 70 review comments in 1 month, and 406 in 1 year
           Xisco Fauli made 70 review comments in 1 month, and 784 in 1 year
           Grandin, Noel made 66 review comments in 1 month, and 622 in 1 year
           Hossein made 52 review comments in 1 month, and 268 in 1 year
     + Patches automatically abandoned:
       + Processed the patches from the people not in the commiters lists
         https://gerrit.libreoffice.org/admin/groups/70c36bd1bfcbef2d3bcfc25622e8aaf57d99bb7c,members
         tdf#128531 make Heading 3 font size 100% ( Seth Chaiklin ) -> commiter
             - https://gerrit.libreoffice.org/#/c/109117
         WIN replace clipboard update thread with Idle, v2 ( Jan-Marek Glogowski )  -> commiter
             - https://gerrit.libreoffice.org/#/c/109829
         tdf#131423 added a function test ( Vikram Shishupalsingh Bais ) -> Restored, has value, but wrong in current form
             - https://gerrit.libreoffice.org/#/c/112165
         tdf#131096 - Create uitest script ( Mani Kumar ) -> Restored, has value, but wrong in current form, author not active anymore
             - https://gerrit.libreoffice.org/#/c/113427
         sw finish current page layout on Idle interrupt ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/114105
         tdf#48140 - Remove uno calls from xlsx import ( Advait Ranade ) -> AUthor no longer active
             - https://gerrit.libreoffice.org/#/c/114764
         Mapping Screenshot to corresponding Unit Ids ( sary  nasser ) -> Author no longer active
             - https://gerrit.libreoffice.org/#/c/118884
         WIP: async popup menus ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/125341
         Fix style ( Behrad Khorram ) -> No value
             - https://gerrit.libreoffice.org/#/c/132500
         WIP resize gstreamer player overlay with window ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/134865
         WIP VCL unify un-maximize handling ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/135529
         WIP gtk: don't lie about frame size ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/135530
         VCL use common interface for "drawables" ( Jan-Marek Glogowski ) -> commiter
             - https://gerrit.libreoffice.org/#/c/136255
         tdf#141908 CppUnittests: replace usage of sal_Int32 with colors ( Robert Nyamugada ) -> Wrong in the current form
             - https://gerrit.libreoffice.org/#/c/137539
         svl : use std::mutex in passwordcontainer ( Arnaud Versini ) -> commiter
             - https://gerrit.libreoffice.org/#/c/138886
         wip: Handle modified table styles on slide copying ( Maxim Monastirsky ) -> commiter
             - https://gerrit.libreoffice.org/#/c/143596
         tdf#151359 make DefaultName optional in Country element of localedata ( Christian Lohmaier ) -> commiter
             - https://gerrit.libreoffice.org/#/c/145465
         tdf#148251 - Use std::swap instead of using temporary values ( Vinit Agarwal ) -> Wrong in the current form
             - https://gerrit.libreoffice.org/#/c/148281
         solving code formatting issues ( Luigi Iucci ) -> Unclear goals
             - https://gerrit.libreoffice.org/#/c/148895
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Cristina Mustatea

* Commit Access

* Developer Certification (Stephan/Miklos/Thorsten/László)
   + resting since: 8 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
   + seems to be working as usual

* Impress Remote poor wifi handling (Michael S)
   + https://gerrit.libreoffice.org/c/core/+/159786
   + bluetooth is better
   + the wifi layear doesn't provide the same safe channel
   + new config setting: enable remote only enables bluetooth
     + second checkbox also enables wifi, which is not recommended
   + in theory, a TLS-SRP would be useful
     + but only supported by openssl -> put that aside for now
   + verified that bluetooth continues to work
   + quality of the slide previews are poor, though (Hossein)
   + right now unencrypted URP is also allowed
     + added a setting where you can disable the URP completely (Michael S)
       + assume it's used in server applications, where you don't have an end user
       + would be nice to have this connection encrypted
       + would be nice to secure this (Hossein)
         + you need to enable this manually, wouldn't worrry (Michael S)
         + it still wouldn't help (Thorsten)
           + even if it's encrypted, still everyone can connect to it
           + not seeing the point
           + no authentication (Michael S)
           + don't think we should be bothered (Thorsten)
           + this is listening on localhost / local pipe
       + we currently default to allow the switch to enable the URP (Michael S)

* What’s cooking (Miklos)
     + Multi-page floating tables in Writer, see tdf#157119 for details (Miklos)
       + worked on some bugfixes
     + A11y update (Michael W)
       + support for block quote role for gtk4
     + Import of Word drawing canvas (Regina)
       + Noel pointed out some unused code
       + text-on-shape-in-group is not correctly imported, will investigate
       + curved connectors: made some import/export progress
         + current UNO API exposes the wrong value for a property -> needs fixing
       + will do it after text-on-shape-in-group

* QA update (Xisco)


     + UNCONFIRMED: 1008 (+3)
         + enhancements: 235  (-9)
         + needsUXEval: 8 (+0)
         + haveBackTrace: 11 (+0)
         + needsDevAdvice: 35 (+0)
         + documentation:  4 (+0)
         + android:  2 (+2)
         + iOS:  0 (+0)
         + Online:  10 (-1)

     + Most pressing bugs:
      New:
          None
      Old:
         + LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian (Bokmål) locale when opening file dialog
             + https://bugs.documentfoundation.org/show_bug.cgi?id=157135
             + Cloph thinks this is related to lightproof (Ilmari)
             + it's suspected to be about localised date & time formats
             + you don't need a Norwegian spellchecker, the locale is enough
             + the English lightproof will also show the problem
             + will CC Laszlo in the bug
         + is it possible to check for such problems in uitests? (Hossein)
           + suggest to have a fix first (Michael)

     + New high severity bugs of the week:
         None

* QA stats (Stéphane)
     + https://bugs.documentfoundation.org/show_bug.cgi?id=76700 - object animation only after second click
     + https://bugs.documentfoundation.org/show_bug.cgi?id=143917 - Row's "optimal height" does not adapt for fonts needing extra vertical space (Thai, Javanese, Arabic, Japanese...)
     + Weekly focus: https://pad.documentfoundation.org/p/qa
         + last week: QA:needsComment went from 160 to 135
         + this week: Android Viewer, already 24 reports touched. Thanks in particular to Kira, Sophie, Michael W.!
         + next week: suggestions ? Navigator is an option.
            + Idea from Heiko: fonts rtl/ctl/cjk?
             + agree (Hossein)
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html and https://stragu.shinyapps.io/lo_qa_dashboard/
       +88  +24 (-89) overall)
       many thanks to the top bug squashers:
        Stéphane Guillou (stragu) 24
        QA Administrators       15
        Balázs Varga (allotropia) 8
        Heiko Tietze            5
        Noel Grandin            3
        Andreas Heinisch        2
        Gabor Kelemen (allotropia) 2
        Justin L                2
        Michael Weghorn         2
        Mike Kaganski           2

     + top 10 bugs reporters:
        Gabor Kelemen (allotropia) 11
        Stéphane Guillou (stragu) 3
        Tuomas Hietala          3
        Eyal Rozenberg          2
        Jean-Francois Nifenecker 2
        Jérôme                  2
        Kira Tubo               2
        Mike Kaganski           2
        Mikhail Kukharenko      2
        demo4                   2

     + top 10 bugs fixers:
        Balazs Varga            8
        Grandin, Noel           3
        Heiko Tietze            3
        Andreas Heinisch        2
        Henschel, Regina        2
        Kelemen, Gabor          2
        Samuel Mehrbrodt        2
        Vajna, Miklos           2
        Weghorn, Michael        2
        Balland-Poirier, Laurent 1

     + top 10 bugs confirmers:
        Stéphane Guillou        24
        m.a.riosv               6
        Balazs Varga            4
        Ilmari Lauhakangas      4
        Kira Tubo               4
        Nabet, Julien           4
        Dieter                  3
        Bogdan B                2
        Heiko Tietze            2
        Henschel, Regina        2


* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Stéphane Guillou       3
         Bogdan B               2
         Raal                   1
         Timur                  1
         Xisco Fauli            1


* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Stéphane Guillou       3
         Bogdan B               2
         Raal                   1
         Timur                  1
         Xisco Fauli            1


* all bugs tagged with 'regression'
    + 1216(-3) bugs open of 12969(+11) total 16(+0) high prio.

      done by:
         Kelemen, Gabor         2
         m.a.riosv              2
         Raal                   1
         Robert Großkopf        1
         Stéphane Guillou       1
         Xisco Fauli            1


* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 11(+0)
      Calc          - 2(+0)
      LibreOffice   - 2(+0)
      UI            - 1(+0)

    by OS:
      All           - 12(+0)
      Linux         - 3(+0)
      Mac OS X      - 0(+0)
      Windows       - 1(+0)


* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 424(-2)
      Calc                     - 221(+1)
      Impress                  - 134(-2)
      LibreOffice              - 52(-1)
      Draw                     - 50(+0)
      Crashes                  - 43(-1)
      Base                     - 42(+0)
      Writer: docx filter      - 41(+1)
      UI                       - 37(+0)
      Borders                  - 35(-1)
      Writer: perf             - 34(+1)
      Writer: other filter     - 33(-1)
      Printing and PDF export  - 24(+0)
      RTL                      - 24(+0)
      Chart                    - 22(+0)
      filters and storage      - 22(+4)
      BASIC                    - 18(+0)
      Writer: doc filter       - 15(+0)
      graphics stack           - 12(+0)
      Formula Editor           - 5(+0)
      framework                - 3(+0)
      Extensions               - 2(+0)
      sdk                      - 2(+0)
      Linguistic               - 1(+0)


More information about the LibreOffice mailing list