recent KahanSum change causes a new test failure on ppc64le

[Eike Rathke]

Hi Dan,

On Wednesday, 2023-09-13 13:45:36 +0200, Dan Horák wrote:

> > It would be worth a try to simply call executeFast() only if SC_USE_SSE2
> > is defined, so the failing platforms skip executeUnrolled(), here
> > https://opengrok.libreoffice.org/xref/core/sc/inc/arraysumfunctor.hxx?r=7f15354c#89
> > 
> > Please report back if that helps and I'll prepare another patch.
> 
> I hop I got your idea right and with
> 
> diff --git a/sc/inc/arraysumfunctor.hxx b/sc/inc/arraysumfunctor.hxx
> index c261c120addf..d9a5b805db50 100644
> --- a/sc/inc/arraysumfunctor.hxx
> +++ b/sc/inc/arraysumfunctor.hxx
> @@ -86,7 +86,11 @@ inline KahanSum sumArray(const double* pArray, size_t nSize)
>  {
>      size_t i = 0;
>      const double* pCurrent = pArray;
> +#if 0
>      KahanSum fSum = executeFast(i, nSize, pCurrent);
> +#else
> +    KahanSum fSum = 0.0;
> +#endif
>  
>      // sum rest of the array
>      for (; i < nSize; ++i)
> 
> the test passed on aarch64 on master branch (no reverts or such)

Yup, such I meant. Thanks for confirming.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20230913/5700f97e/attachment.sig>