Re: tdf#156333: Implementing Text Effects

[Амин Иргалиев]

Good day!
We tried to bind tint into the existing tint_or_shade implementation used for theme effects. It looks like this implementation is maked only for themes. At least in the file “sw/source/filter/ww8/docxattributeoutput.cxx line:7782” everything that gets into ComplexColor is exported, in our understanding, as a theme. Are we doing the right thing by trying to binding tint with an already written implementation, or do we need to implement our own processing?
 
If binding is the right solution, then can be will probably need to create separate models for the styles from the themes and the styles of the element itself. In this case, Tomaž Vajngerl, can we contact you with questions about your implementation?
>On Mon, Sep 11, 2023, at 16:11 +04:00, Vladislav Tarakanov <vladislav.tarakanov at bk.ru>:
> 
>We created a new item "SvxTintItem" and updated include/vcl/font.hxx by adding methods for reading and setting tint. We tried to add processing of this value to vcl/source/outdev/text.cxx, to the ImplDrawSpecialText method. At the same time, we started looking for where the tint value was exported.
>
>During the search we found that tint is already used in ComplexColor. We re-checked the use of attributes in unomap1 and unomapproperties and found out that UNO_NAME_CHAR_COLOR_TINT_OR_SHADE is used there. Is there a possibility that we did not need to create a new item, but could have applied the existing tint value processing?
>  
>>On 31/08/2023, 13:36 +04:00, Michael Stahl < mst at libreoffice.org >:
>> 
>>On 30/08/2023 20:24, Tomaž Vajngerl wrote:
>>> Hi,
>>>
>>> On Tue, Aug 29, 2023 at 12:30PM Amin Irgaliev < irgaliev01 at mail.ru > wrote:
>>>>
>>>> It is possible that the model we need is in sw/source/core/inc/swfont.hxx.
>>>
>>> Yes, looks like the correct place (not exactly sure), but that would
>>> add it only for Writer (which is fine for now). I would trace how the
>>> "Relief" parameter (or "Shadow") is used and manipulated as that's
>>> kind-of a text effect that's already implemented. Best to go down from
>>> OOXML import and look how the font attributes are set...
>>adding it to the model needs a new SfxPoolItem subclass, and a new
>>WhichId in sw/inc/hintids.hxx, to be inserted before RES_CHRATR_END.
>>
>>the item is used in SwTextNode item set, in SwFormatColl item set, and
>>in the SwFormatAutoFormat item set (which is used with
>>RES_TXTATR_AUTOFMT for formatted text portions inside a paragraph).
>>
>>the SwFont is then used during the text formatting, there is an array
>>somewhere ... in SwAttrHandler that will need an extra entry for the new
>>item. 
> 
> 
>--
>Vladislav Tarakanov
>  
 
 
--
Sincerely,
Irgaliev Amin
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20230921/40acfd2b/attachment.htm>