New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
67 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1615991:  Control flow issues  (DEADCODE)
/cui/source/tabpages/numfmt.cxx: 428 in SvxNumberFormatTabPage::Reset(const SfxItemSet *)()


________________________________________________________________________________________________________
*** CID 1615991:  Control flow issues  (DEADCODE)
/cui/source/tabpages/numfmt.cxx: 428 in SvxNumberFormatTabPage::Reset(const SfxItemSet *)()
422     
423         if ( const SfxBoolItem* pBoolItem = rSet->GetItemIfSet( SID_ATTR_NUMBERFORMAT_SOURCE ))
424         {
425             if ( pBoolItem )
426                 m_xCbSourceFormat->set_active(pBoolItem->GetValue());
427             else
>>>     CID 1615991:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "this->m_xCbSourceFormat->se...".
428                 m_xCbSourceFormat->set_active( false );
429             m_xCbSourceFormat->set_sensitive(true);
430             m_xCbSourceFormat->show();
431         }
432         else
433         {

** CID 1615990:  Insecure data handling  (INTEGER_OVERFLOW)


________________________________________________________________________________________________________
*** CID 1615990:  Insecure data handling  (INTEGER_OVERFLOW)
/package/source/zipapi/ZipFile.cxx: 1310 in ZipFile::readCEN()()
1304             if (SAL_MAX_INT32 < nCenLen)
1305             {
1306                 throw ZipException(u"central directory too big"_ustr);
1307             }
1308     
1309             aGrabber.seek(nCenPos);
>>>     CID 1615990:  Insecure data handling  (INTEGER_OVERFLOW)
>>>     "nCenLen", which might have overflowed, is passed to "aCENBuffer.Sequence(nCenLen)".
1310             Sequence < sal_Int8 > aCENBuffer ( nCenLen );
1311             sal_Int64 nRead = aGrabber.readBytes ( aCENBuffer, nCenLen );
1312             if ( static_cast < sal_Int64 > ( nCenLen ) != nRead )
1313                 throw ZipException (u"Error reading CEN into memory buffer!"_ustr );
1314     
1315             MemoryByteGrabber aMemGrabber(aCENBuffer);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DS016_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtIVnvt-2B7kur9Ch0g1EgdB3AXj12SxxDneLvfA1yBDa-2Fc429TVTxBaj9ZP-2Fpr5DnQuhSKZ-2F6OAKwTZB-2FO5bLtBSLecQCu1hKWkuPHLVJSKugdygXkqqUGTZCQTCXMLx8-2FP1Ucx8kKYkZlHiAe1qB4jjYPyRgIlNWXDETCkMAA55Lc-3D