New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
59 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1616507:  Incorrect expression  (ASSERT_SIDE_EFFECT)
/sw/source/core/doc/textboxhelper.cxx: 68 in SwTextBoxHelper::create(SwFrameFormat *, SdrObject *, bool)()


________________________________________________________________________________________________________
*** CID 1616507:  Incorrect expression  (ASSERT_SIDE_EFFECT)
/sw/source/core/doc/textboxhelper.cxx: 68 in SwTextBoxHelper::create(SwFrameFormat *, SdrObject *, bool)()
62     using namespace com::sun::star;
63     
64     void SwTextBoxHelper::create(SwFrameFormat* pShape, SdrObject* pObject, bool bCopyText)
65     {
66         assert(pShape);
67         assert(pObject);
>>>     CID 1616507:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Assignment "pShape = FindFrameFormat(pObject)" has a side effect.  This code will work differently in a non-debug build.
68         assert(pShape = ::FindFrameFormat(pObject));
69     
70         // If TextBox wasn't enabled previously
71         if (pShape->GetOtherTextBoxFormats() && pShape->GetOtherTextBoxFormats()->GetTextBox(pObject))
72             return;
73     

** CID 1616506:  Resource leaks  (RESOURCE_LEAK)
/sc/source/ui/condformat/condformateasydlg.cxx: 390 in sc::ConditionalFormatEasyDialog::ButtonPressed(weld::Button &)()


________________________________________________________________________________________________________
*** CID 1616506:  Resource leaks  (RESOURCE_LEAK)
/sc/source/ui/condformat/condformateasydlg.cxx: 390 in sc::ConditionalFormatEasyDialog::ButtonPressed(weld::Button &)()
384                 pFormat->SetRange(aRange);
385                 auto& rRangeList = pFormat->GetRange();
386                 mpViewData->GetDocShell()->GetDocFunc().ReplaceConditionalFormat(
387                     0, std::move(pFormat), maPosition.Tab(), rRangeList);
388             }
389             m_xDialog->response(RET_OK);
>>>     CID 1616506:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "pEntry" going out of scope leaks the storage it points to.
390         }
391         else if (&rButton == mxButtonCancel.get())
392             m_xDialog->response(RET_CANCEL);
393     }
394     
395     IMPL_LINK_NOARG(ConditionalFormatEasyDialog, StyleSelectHdl, weld::ComboBox&, void)

** CID 1616505:    (UNINIT_CTOR)
/sc/source/ui/condformat/condformateasydlg.cxx: 277 in sc::ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings *, SfxChildWindow *, weld::Window *, ScViewData *)()
/sc/source/ui/condformat/condformateasydlg.cxx: 277 in sc::ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings *, SfxChildWindow *, weld::Window *, ScViewData *)()


________________________________________________________________________________________________________
*** CID 1616505:    (UNINIT_CTOR)
/sc/source/ui/condformat/condformateasydlg.cxx: 277 in sc::ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings *, SfxChildWindow *, weld::Window *, ScViewData *)()
271     
272         StartListening(*mpDocument->GetStyleSheetPool(), DuplicateHandling::Prevent);
273         ScCondFormatHelper::FillStyleListBox(mpDocument, *mxStyles);
274     
275         mxStyles->set_active(1);
276         mxWdPreviewWin->show();
>>>     CID 1616505:    (UNINIT_CTOR)
>>>     Non-static class member "mnEntryIndex" is not initialized in this constructor nor in any functions that it calls.
277     }
278     
279     ConditionalFormatEasyDialog::~ConditionalFormatEasyDialog()
280     {
281         if (mbIsManaged)
282         {
/sc/source/ui/condformat/condformateasydlg.cxx: 277 in sc::ConditionalFormatEasyDialog::ConditionalFormatEasyDialog(SfxBindings *, SfxChildWindow *, weld::Window *, ScViewData *)()
271     
272         StartListening(*mpDocument->GetStyleSheetPool(), DuplicateHandling::Prevent);
273         ScCondFormatHelper::FillStyleListBox(mpDocument, *mxStyles);
274     
275         mxStyles->set_active(1);
276         mxWdPreviewWin->show();
>>>     CID 1616505:    (UNINIT_CTOR)
>>>     Non-static class member "mnEntryIndex" is not initialized in this constructor nor in any functions that it calls.
277     }
278     
279     ConditionalFormatEasyDialog::~ConditionalFormatEasyDialog()
280     {
281         if (mbIsManaged)
282         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DDXpT_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtXiEFgvek0Oy1x58ELBohFgZJn6T4t9NynMeW8sg0oyjafEfK3YWdwvYLv5EH4xjNcCjFoQOmA8Atk44U7Q-2Bmi5p0e6nVB2Lj9vNsRAVriCjAnqs6g8f8uabqtr5tpeEAH-2B9nNGYpXh28ovTNERUDmIqNxS2MUkvt4AC9LjCzeBY-3D