New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1637333:  Possible Control flow issues  (DEADCODE)
/sw/source/core/docnode/node.cxx: 1191 in SwContentNode::SwClientNotify(const SwModify &, const SfxHint &)()


________________________________________________________________________________________________________
*** CID 1637333:  Possible Control flow issues  (DEADCODE)
/sw/source/core/docnode/node.cxx: 1191 in SwContentNode::SwClientNotify(const SwModify &, const SfxHint &)()
1185                     assert(dynamic_cast<const SwUpdateAttr*>(pLegacyHint->m_pNew));
1186                     const SwUpdateAttr aFallbackHint(0,0,0);
1187                     const SwUpdateAttr& rUpdateAttr = pLegacyHint->m_pNew ? *static_cast<const SwUpdateAttr*>(pLegacyHint->m_pNew) : aFallbackHint;
1188                     UpdateAttr(rUpdateAttr);
1189                     return;
1190             }
>>>     CID 1637333:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "this->GetpSwAttrSet()" inside this statement: "if (bSetParent && this->Get...".
1191             if(bSetParent && GetpSwAttrSet())
1192                 AttrSetHandleHelper::SetParent(mpAttrSet, *this, pFormatColl, pFormatColl);
1193             if(bCalcHidden)
1194                 static_cast<SwTextNode*>(this)->SetCalcHiddenCharFlags();
1195             CallSwClientNotify(rHint);
1196         }

** CID 1637332:  Possible Control flow issues  (DEADCODE)
/sw/source/core/docnode/node.cxx: 1133 in SwContentNode::SwClientNotify(const SwModify &, const SfxHint &)()


________________________________________________________________________________________________________
*** CID 1637332:  Possible Control flow issues  (DEADCODE)
/sw/source/core/docnode/node.cxx: 1133 in SwContentNode::SwClientNotify(const SwModify &, const SfxHint &)()
1127                 bSetParent = true;
1128             }
1129     
1130             if(bSetParent && GetpSwAttrSet())
1131                 AttrSetHandleHelper::SetParent(mpAttrSet, *this, pFormatColl, pFormatColl);
1132             if(bCalcHidden)
>>>     CID 1637332:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "static_cast<SwTextNode *>(t...".
1133                 static_cast<SwTextNode*>(this)->SetCalcHiddenCharFlags();
1134             CallSwClientNotify(rHint);
1135         }
1136         else if (rHint.GetId() == SfxHintId::SwLegacyModify)
1137         {
1138             auto pLegacyHint = static_cast<const sw::LegacyModifyHint*>(&rHint);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DedFO_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtmyITnYP0oomhTNdsMKC-2F-2FQXkP3G0-2BiWmHiAuix2EF3t37b7JfIHRq6m0DYLN-2FBeWhDRnl8rKpr-2FLGv7aUkJ0iCV-2FJdfuDIjOMYYCWAZ44gulgKG1vly3cG1ICFuJ9kEPDLpE4TgD8-2F8Rv-2FD3OqXUxORLYy-2FGV9WMauNWMSOxB28-3D