master build broken on macOS due to Firebird update

Sat Jan 6 15:53:38 UTC 2024

Bad news: this update is worse than I thought when doing a clean debug 
build after doing a make clean. I am seeing a lengthy list of all sorts 
of different warnings being converted to errors. There are still a lot 
of sprintf errors, but now there are even more other, different warnings.

See attached build log for a list of warnings converted to errors that I 
am seeing.

Can anyone actually do a debug build on any other platform on master 
with this update? IIRC Windows also has to suppress deprecation 
warnings, at least for sprintf, but maybe I am wrong.

Patrick

On 2024-01-06 10:20 a.m., Patrick Luby wrote:
> All,
> 
> I am not sure how this update built successfully on macOS on Jenkins, 
> but the Firebird update is filled with hundreds of sprintf calls like 
> the following. Xcode has marked sprintf as deprecated since a couple of 
> versions ago:
> 
> /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/temp/Debug/isql/show.cpp:6986:5: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
>                                  sprintf(info, "Number of DB pages free 
> = %" SQUADFORMAT"%s", value_out, separator);
> 
> So how do we suppress these "en masse" when doing debug builds?
> 
> Thanks,
> 
> Patrick
-------------- next part --------------
The Firebird3 package has been configured with the following options:

                    Raw devices : disabled
                   Service name : gds_db
                   Service port : 3050
                   GPRE modules : c_cxx.cpp

                    Install Dir : /usr/local/firebird

ld: warning: ignoring duplicate libraries: '-liconv'
ld: warning: ignoring duplicate libraries: '-liconv'
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/Parser.cpp:25:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/Parser.h:26:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/dsql.h:47:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/Attachment.h:155:21: warning: increment of object of volatile-qualified type 'volatile FB_UINT64' (aka 'volatile unsigned long long') is deprecated [-Wdeprecated-volatile]
                        totalLocksCounter++;
                                         ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/Attachment.h:174:21: warning: increment of object of volatile-qualified type 'volatile FB_UINT64' (aka 'volatile unsigned long long') is deprecated [-Wdeprecated-volatile]
                        totalLocksCounter++;
                                         ^
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/Parser.cpp:25:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/Parser.h:27:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/DdlNodes.h:31:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/Nodes.h:26:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/jrd.h:55:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/os/guid.h:71:2: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, GUID_LEGACY_FORMAT,
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/stdio.h:180:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/Parser.cpp:25:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/Parser.h:27:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/DdlNodes.h:31:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/Nodes.h:26:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/jrd.h:56:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../jrd/sbm.h:32:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:289:12: warning: enumeration values 'locEqual', 'locGreatEqual', and 'locLessEqual' not handled in switch [-Wswitch]
                        switch (lt)
                                ^~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:289:12: note: add missing switch cases
                        switch (lt)
                                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:313:12: warning: enumeration values 'locLess' and 'locGreat' not handled in switch [-Wswitch]
                        switch (lt)
                                ^~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:313:12: note: add missing switch cases
                        switch (lt)
                                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/Parser.cpp:37:12: warning: unused variable 'HASH_SIZE' [-Wunused-const-variable]
        const int HASH_SIZE = 1021;
                  ^
6 warnings generated.
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:39:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../dsql/dsql.h:47:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/Attachment.h:155:21: warning: increment of object of volatile-qualified type 'volatile FB_UINT64' (aka 'volatile unsigned long long') is deprecated [-Wdeprecated-volatile]
                        totalLocksCounter++;
                                         ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/Attachment.h:174:21: warning: increment of object of volatile-qualified type 'volatile FB_UINT64' (aka 'volatile unsigned long long') is deprecated [-Wdeprecated-volatile]
                        totalLocksCounter++;
                                         ^
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:44:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/jrd.h:55:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/os/guid.h:71:2: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, GUID_LEGACY_FORMAT,
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/stdio.h:180:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.2.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:44:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/jrd.h:56:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../jrd/sbm.h:32:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:289:12: warning: enumeration values 'locEqual', 'locGreatEqual', and 'locLessEqual' not handled in switch [-Wswitch]
                        switch (lt)
                                ^~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:289:12: note: add missing switch cases
                        switch (lt)
                                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:313:12: warning: enumeration values 'locLess' and 'locGreat' not handled in switch [-Wswitch]
                        switch (lt)
                                ^~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/include/../jrd/../common/classes/sparse_bitmap.h:313:12: note: add missing switch cases
                        switch (lt)
                                ^
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:67:
In file included from /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/trace/TraceManager.h:39:
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/trace/../../jrd/trace/TraceConfigStorage.h:108:47: warning: increment of object of volatile-qualified type 'volatile ULONG' (aka 'volatile unsigned int') is deprecated [-Wdeprecated-volatile]
                                m_sharedMemory->getHeader()->change_number++;
                                                                          ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/../jrd/trace/../../jrd/trace/TraceConfigStorage.h:151:3: warning: delete called on non-final 'Jrd::ConfigStorage' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
                delete storage;
                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:94:10: warning: 17 enumeration values not handled in switch: 'TYPE_INSERT', 'TYPE_DELETE', 'TYPE_UPDATE'... [-Wswitch]
        switch (type)
                ^~~~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:94:10: note: add missing switch cases
        switch (type)
                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:791:10: warning: 18 enumeration values not handled in switch: 'TYPE_SELECT', 'TYPE_SELECT_UPD', 'TYPE_INSERT'... [-Wswitch]
        switch (statement->getType())
                ^~~~~~~~~~~~~~~~~~~~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:791:10: note: add missing switch cases
        switch (statement->getType())
                ^
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:1767:12: warning: 15 enumeration values not handled in switch: 'TYPE_INSERT', 'TYPE_DELETE', 'TYPE_UPDATE'... [-Wswitch]
                        switch (statement->getType())
                                ^~~~~~~~~~~~~~~~~~~~
/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/src/dsql/dsql.cpp:1767:12: note: add missing switch cases
                        switch (statement->getType())
                                ^
10 warnings generated.
ld: warning: ignoring duplicate libraries: '-liconv', '-ltommath'
dyld[40707]: Library not loaded: @rpath/lib/libfbclient.dylib
  Referenced from: <CA46400F-F1C2-449D-ADB5-615E2E0363CB> /Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql
  Reason: tried: '/Volumes/LOBuilds/lode/dev/core/instdir/LibreOfficeDev.app/Contents/Frameworks/libfbclient.dylib' (no such file), '/Volumes/LOBuilds/lode/dev/core/instdir/LibreOfficeDev.app/Contents/Frameworks/libfbclient.dylib' (no such file), '/Volumes/LOBuilds/lode/dev/core/workdir/UnpackedTarball/icu/source/lib/libfbclient.dylib' (no such file)
make[5]: *** [Makefile:367: metadata.fdb] Abort trap: 6
make[4]: *** [Makefile:197: master_process] Error 2
make[3]: *** [Makefile:72: Debug] Error 2
make[2]: *** [Makefile:6: Debug] Error 2
make[1]: *** [/Volumes/LOBuilds/lode/dev/core/external/firebird/ExternalProject_firebird.mk:30: /Volumes/LOBuilds/lode/dev/core/workdir/ExternalProject/firebird/build] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:290: build] Error 2