New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
29 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1586677:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/rtl/string.hxx: 191 in ()


________________________________________________________________________________________________________
*** CID 1586677:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/rtl/string.hxx: 191 in ()
185     
186       The design of this class is similar to the string classes in Java
187       and so more people should have fewer understanding problems when they
188       use this class.
189     */
190     
>>>     CID 1586677:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "rtl::OString" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
191     class SAL_WARN_UNUSED SAL_DLLPUBLIC_RTTI OString
192     {
193     public:
194         /// @cond INTERNAL
195         rtl_String * pData;
196         /// @endcond

** CID 1586676:  Performance inefficiencies  (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/unordered_set.h: 77 in frozen::unordered_set<std::basic_string_view<char16_t, std::char_traits<char16_t>>, (unsigned long)14, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>, std::equal_to<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::unordered_set(frozen::bits::carray<std::basic_string_view<char16_t, std::char_traits<char16_t>>, (unsigned long)14>, const frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>> &, const std::equal_to<std::basic_string_view<char16_t, std::char_traits<char16_t>>> &)()


________________________________________________________________________________________________________
*** CID 1586676:  Performance inefficiencies  (PASS_BY_VALUE)
/workdir/UnpackedTarball/frozen/include/frozen/unordered_set.h: 77 in frozen::unordered_set<std::basic_string_view<char16_t, std::char_traits<char16_t>>, (unsigned long)14, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>>, std::equal_to<std::basic_string_view<char16_t, std::char_traits<char16_t>>>>::unordered_set(frozen::bits::carray<std::basic_string_view<char16_t, std::char_traits<char16_t>>, (unsigned long)14>, const frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t>>> &, const std::equal_to<std::basic_string_view<char16_t, std::char_traits<char16_t>>> &)()
71       using const_iterator = const_pointer;
72       using iterator = const_iterator;
73     
74     public:
75       /* constructors */
76       unordered_set(unordered_set const &) = default;
>>>     CID 1586676:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Passing parameter keys of type "frozen::unordered_set<std::basic_string_view<char16_t, std::char_traits<char16_t> >, 14ul, frozen::elsa<std::basic_string_view<char16_t, std::char_traits<char16_t> > >, std::equal_to<std::basic_string_view<char16_t, std::char_traits<char16_t> > > >::container_type" (size 224 bytes) by value, which exceeds the low threshold of 128 bytes.
77       constexpr unordered_set(container_type keys, Hash const &hash,
78                               KeyEqual const &equal)
79           : equal_{equal}
80           , keys_{keys}
81           , tables_{bits::make_pmh_tables<storage_size>(
82                 keys_, hash, bits::Get{}, default_prg_t{})} {}

** CID 1586675:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustring.hxx: 170 in ()


________________________________________________________________________________________________________
*** CID 1586675:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/rtl/ustring.hxx: 170 in ()
164       functionalities and avoids too much memory allocation.
165     
166       The design of this class is similar to the string classes in Java so
167       less people should have understanding problems when they use this class.
168     */
169     
>>>     CID 1586675:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "rtl::OUString" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
170     class SAL_WARN_UNUSED SAL_DLLPUBLIC_RTTI OUString
171     {
172     public:
173         /// @cond INTERNAL
174         rtl_uString * pData;
175         /// @endcond


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DokP__OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiBq57mMQEVtuAdBaxLBfjo7rODALKx71sJkVhbvUlxq4S6r-2FAmZlhPS82Bppp4qpJL9O0ChWUUgXWYB4Lb1kJ1ifrfM3OGXwMA7i-2F9VJvjS9kJWy9ijbuFuv7twJwDIXg138-2B9DE6bWTiiqFgRmr4WdKR8lQ2k5uWlWjIkL3LChQ-3D