New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1610739:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx: 1549 in writerfilter::dmapper::DomainMapper_Impl::GetInheritedParaProperty(writerfilter::dmapper::PropertyIds)()


________________________________________________________________________________________________________
*** CID 1610739:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx: 1549 in writerfilter::dmapper::DomainMapper_Impl::GetInheritedParaProperty(writerfilter::dmapper::PropertyIds)()
1543             pEntry = pEntry = GetStyleSheetTable()->FindStyleSheetByISTD(
1544                 GetStyleSheetTable()->GetCurrentEntry()->m_sBaseStyleIdentifier);
1545         else
1546             pEntry = GetStyleSheetTable()->FindStyleSheetByConvertedStyleName(GetCurrentParaStyleName());
1547     
1548         const bool bCheckDocDefaults = !IsDocDefaultsImport();
>>>     CID 1610739:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "pEntry" is passed-by-value as parameter to "GetPropertyFromStyleSheet" when it could be moved instead.
1549         return GetPropertyFromStyleSheet(eId, pEntry, bCheckDocDefaults, /*bPara=*/true);
1550     }
1551     
1552     uno::Any DomainMapper_Impl::GetPropertyFromCharStyleSheet(PropertyIds eId, const PropertyMapPtr& rContext)
1553     {
1554         if ( m_bInStyleSheetImport || eId == PROP_CHAR_STYLE_NAME || !isCharacterProperty(eId) )

** CID 1610738:  Control flow issues  (DEADCODE)
/vcl/source/control/imivctl1.cxx: 1032 in SvxIconChoiceCtrl_Impl::PaintEntry(SvxIconChoiceCtrlEntry *, const Point &, OutputDevice &)()


________________________________________________________________________________________________________
*** CID 1610738:  Control flow issues  (DEADCODE)
/vcl/source/control/imivctl1.cxx: 1032 in SvxIconChoiceCtrl_Impl::PaintEntry(SvxIconChoiceCtrlEntry *, const Point &, OutputDevice &)()
1026             else
1027                 aNewFont.SetFillColor(rSettings.GetDeactiveColor());
1028     
1029             Color aTextColor(rSettings.GetTabTextColor());
1030             if (bSelected)
1031                 aTextColor = rSettings.GetTabHighlightTextColor();
>>>     CID 1610738:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "if (bMouseHovered)
  aTextC...".
1032             else if (bMouseHovered)
1033                 aTextColor = rSettings.GetTabRolloverTextColor();
1034             aNewFont.SetColor(aTextColor);
1035     
1036             rRenderContext.SetFont(aNewFont);
1037     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D_Yu8_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtX2vmD9iJKtmpcEVqjWkQQaoN7qw0GPVnbpO-2F6h9Xq-2F-2FW14f83UPpfBO9R90QyIWH-2Fll2PHIwkkAcVGvNAPUHf7u3giVNusI0yph0zsmBWZ6AXTd6DeGsHvieLDxCLoHU3J6sndy8KuHFimSyde1vK2qfG9AN0WSHApWTVWh17MQ-3D