New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1596834:  Incorrect expression  (IDENTICAL_BRANCHES)
/sw/source/core/bastyp/calc.cxx: 127 in OperatorCompare(const void *, const void *)()


________________________________________________________________________________________________________
*** CID 1596834:  Incorrect expression  (IDENTICAL_BRANCHES)
/sw/source/core/bastyp/calc.cxx: 127 in OperatorCompare(const void *, const void *)()
121     extern "C" {
122     static int OperatorCompare( const void *pFirst, const void *pSecond)
123     {
124         int nRet = 0;
125         if( CALC_NAME == static_cast<const CalcOp*>(pFirst)->eOp )
126         {
>>>     CID 1596834:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed regardless of whether "CALC_NAME == static_cast<CalcOp const *>(pSecond)->eOp" is true, because the 'then' and 'else' branches are identical. Should one of the branches be modified, or the entire 'if' statement replaced?
127             if( CALC_NAME == static_cast<const CalcOp*>(pSecond)->eOp )
128                 nRet = static_cast<const CalcOp*>(pFirst)->aName.compareTo(
129                         static_cast<const CalcOp*>(pSecond)->aName );
130             else
131                 nRet = static_cast<const CalcOp*>(pFirst)->aName.compareTo(
132                          static_cast<const CalcOp*>(pSecond)->aName );

** CID 1596833:  Uninitialized members  (UNINIT_CTOR)
/svgio/source/svgreader/svgstyleattributes.cxx: 1299 in svgio::svgreader::SvgStyleAttributes::SvgStyleAttributes(svgio::svgreader::SvgNode &)()


________________________________________________________________________________________________________
*** CID 1596833:  Uninitialized members  (UNINIT_CTOR)
/svgio/source/svgreader/svgstyleattributes.cxx: 1299 in svgio::svgreader::SvgStyleAttributes::SvgStyleAttributes(svgio::svgreader::SvgNode &)()
1293                 maBaselineShiftNumber(0),
1294                 maDominantBaseline(DominantBaseline::Auto),
1295                 maResolvingParent(33, 0),
1296                 mbStrokeDasharraySet(false),
1297                 mbContextStroke(false)
1298             {
>>>     CID 1596833:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "maContextStroke" is not initialized in this constructor nor in any functions that it calls.
1299             }
1300     
1301             SvgStyleAttributes::~SvgStyleAttributes()
1302             {
1303             }
1304     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DlzJ__A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtOnfJZXHZ0I-2BqvltHif1tKV6yUEK1nhCUEgrcGEHrlPYeDXLVLxGWnFQ4LOE4envtKartEpNvFsISrxil-2FMFDR5UkOz-2F2yuhJwW5QIoF7buabPX8X61cIlC6IfrAucuT4myWy7ENT7GeX7IaV6w5R4Pc-2F0sINIUWmfjVGhSgs6K0-3D