New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1597307:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/misc/asyncmodaldialog.cxx: 68 in dbaui::<unnamed>::DialogExecutor_Impl::onExecute(void *)()


________________________________________________________________________________________________________
*** CID 1597307:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/misc/asyncmodaldialog.cxx: 68 in dbaui::<unnamed>::DialogExecutor_Impl::onExecute(void *)()
62         }
63     
64         IMPL_LINK_NOARG( DialogExecutor_Impl, onExecute, void*, void )
65         {
66             try
67             {
>>>     CID 1597307:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "execute" without checking return value (as is done elsewhere 32 out of 39 times).
68                 m_xDialog->execute();
69             }
70             catch( const Exception& )
71             {
72                 DBG_UNHANDLED_EXCEPTION("dbaccess");
73             }

** CID 1597306:  Error handling issues  (CHECKED_RETURN)
/svx/source/form/fmshimp.cxx: 1394 in FmXFormShell::ExecuteTabOrderDialog_Lock(const com::sun::star::uno::Reference<com::sun::star::awt::XTabControllerModel> &)()


________________________________________________________________________________________________________
*** CID 1597306:  Error handling issues  (CHECKED_RETURN)
/svx/source/form/fmshimp.cxx: 1394 in FmXFormShell::ExecuteTabOrderDialog_Lock(const com::sun::star::uno::Reference<com::sun::star::awt::XTabControllerModel> &)()
1388     
1389             Reference< dialogs::XExecutableDialog > xDialog = form::TabOrderDialog::createWithModel(
1390                     comphelper::getProcessComponentContext(),
1391                     _rxForForm, getControlContainerForView_Lock(), xParentWindow
1392                 );
1393     
>>>     CID 1597306:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "execute" without checking return value (as is done elsewhere 32 out of 39 times).
1394             xDialog->execute();
1395         }
1396         catch( const Exception& )
1397         {
1398             TOOLS_WARN_EXCEPTION( "svx", "FmXFormShell::ExecuteTabOrderDialog" );
1399         }

** CID 1597305:  Error handling issues  (CHECKED_RETURN)
/sc/source/ui/app/scmod.cxx: 535 in ScModule::Execute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1597305:  Error handling issues  (CHECKED_RETURN)
/sc/source/ui/app/scmod.cxx: 535 in ScModule::Execute(SfxRequest &)()
529     
530             case SID_OPEN_XML_FILTERSETTINGS:
531             {
532                 try
533                 {
534                     css::uno::Reference < css::ui::dialogs::XExecutableDialog > xDialog = css::ui::dialogs::XSLTFilterDialog::create( ::comphelper::getProcessComponentContext());
>>>     CID 1597305:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "execute" without checking return value (as is done elsewhere 32 out of 39 times).
535                     xDialog->execute();
536                 }
537                 catch( css::uno::RuntimeException& )
538                 {
539                     DBG_UNHANDLED_EXCEPTION("sc.ui");
540                 }

** CID 1597304:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/misc/TableCopyHelper.cxx: 110 in dbaui::OTableCopyHelper::insertTable(std::basic_string_view<char16_t, std::char_traits<char16_t>>, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const rtl::OUString &, int, const com::sun::star::uno::Reference<com::sun::star::sdbc::XResultSet> &, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> &, bool, std::basic_string_view<char16_t, std::char_traits<char16_t>>, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &)()


________________________________________________________________________________________________________
*** CID 1597304:  Error handling issues  (CHECKED_RETURN)
/dbaccess/source/ui/misc/TableCopyHelper.cxx: 110 in dbaui::OTableCopyHelper::insertTable(std::basic_string_view<char16_t, std::char_traits<char16_t>>, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &, const rtl::OUString &, int, const com::sun::star::uno::Reference<com::sun::star::sdbc::XResultSet> &, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> &, bool, std::basic_string_view<char16_t, std::char_traits<char16_t>>, const com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection> &)()
104             OUString sTableNameForAppend( GetTableNameForAppend() );
105             xWizard->setDestinationTableName( GetTableNameForAppend() );
106     
107             bool bAppendToExisting = !sTableNameForAppend.isEmpty();
108             xWizard->setOperation( bAppendToExisting ? CopyTableOperation::AppendData : CopyTableOperation::CopyDefinitionAndData );
109     
>>>     CID 1597304:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "execute" without checking return value (as is done elsewhere 32 out of 39 times).
110             xWizard->execute();
111         }
112         catch( const SQLException& )
113         {
114             m_pController->showError( SQLExceptionInfo( ::cppu::getCaughtException() ) );
115         }

** CID 1597303:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/control/shell.cxx: 284 in SfxShell::HandleOpenXmlFilterSettings(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1597303:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/control/shell.cxx: 284 in SfxShell::HandleOpenXmlFilterSettings(SfxRequest &)()
278     
279     void SfxShell::HandleOpenXmlFilterSettings(SfxRequest & rReq)
280     {
281         try
282         {
283             uno::Reference < ui::dialogs::XExecutableDialog > xDialog = ui::dialogs::XSLTFilterDialog::create( ::comphelper::getProcessComponentContext() );
>>>     CID 1597303:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "execute" without checking return value (as is done elsewhere 32 out of 39 times).
284             xDialog->execute();
285         }
286         catch (const uno::Exception&)
287         {
288         }
289         rReq.Ignore ();


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DJ2zV_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtpHWOmFGBBPGIjyfEUT8WAG-2FfidIFML8DlTlJQq9CGfOZpQApR6FXgvDR4EdOIbxwjEnI0R-2FQFw44ZsXHzyumYCHCWPNPDGPLjXW-2Fy4UGCR5i6cDu199UIxfLbMo4pDw5-2F-2Bp7zx69bNwhjj-2Bi4XGEv9iQSY1948lu1NCCl-2BJu73I-3D