PVS-Studio report

[Xisco Fauli]

Hello,

The PVS-Studio report is now available at 
https://report.dev.libreoffice.org/ ( Thanks to Guilhem for helping with 
that )

So far I've found three groups of false positives:

1.

AxMultiPageModel* pMultiPage = dynamic_cast< AxMultiPageModel* >( 
pContainerModel );
assert(pMultiPage);
pMultiPage->importPageAndMultiPageProperties( aXStrm, maControls.size() );
↑ V522 There might be dereferencing of a potential null pointer 
'pMultiPage'.

-> it can be fixed with 
https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7

2.

OutlinerView* pOLV = mpDrawView->GetTextEditOutlinerView();
::Outliner* pOL = pOLV ? pOLV->GetOutliner() : nullptr;
if (!pOL)
     return nullptr;
rSel = pOLV->GetSelection();

↑ V1004 The 'pOLV' pointer was used unsafely after it was verified 
against nullptr. Check lines: 241, 244.

-> it's been already reported to them

3.

bool bDropDown = false;
xPropertySet->getPropertyValue(u"DropDown"_ustr) >>= bDropDown;
if (bDropDown)

↑ V547 Expression 'bDropDown' is always false.

-> To be reported

-- 
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0