New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1633191:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 793 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()


________________________________________________________________________________________________________
*** CID 1633191:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 793 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()
787                                   pParent, nullptr, /*bGoingToSetText*/ true);
788     
789         std::unique_ptr<weld::TreeIter> xChildParentIter = rBox.make_iterator(pParent);
790         if (!pParent)
791             rBox.get_iter_first(*xChildParentIter);
792         else
>>>     CID 1633191:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "iter_children" without checking return value (as is done elsewhere 59 out of 61 times).
793             rBox.iter_children(*xChildParentIter);
794         for (size_t i = 0; i < rTreeArray.size(); ++i)
795         {
796             if (i != 0)
797                 rBox.iter_next_sibling(*xChildParentIter);
798             FillBox_Impl(rBox, rTreeArray[i]->getChildren(), eStyleFamily, xChildParentIter.get(),

** CID 1633190:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 797 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()


________________________________________________________________________________________________________
*** CID 1633190:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 797 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()
791             rBox.get_iter_first(*xChildParentIter);
792         else
793             rBox.iter_children(*xChildParentIter);
794         for (size_t i = 0; i < rTreeArray.size(); ++i)
795         {
796             if (i != 0)
>>>     CID 1633190:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "iter_next_sibling" without checking return value (as is done elsewhere 82 out of 85 times).
797                 rBox.iter_next_sibling(*xChildParentIter);
798             FillBox_Impl(rBox, rTreeArray[i]->getChildren(), eStyleFamily, xChildParentIter.get(),
799                          blcl_insert, pViewShell, pStyleSheetPool);
800         }
801     }
802     

** CID 1633189:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 791 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()


________________________________________________________________________________________________________
*** CID 1633189:  Error handling issues  (CHECKED_RETURN)
/sfx2/source/dialog/StyleList.cxx: 791 in FillBox_Impl(weld::TreeView &, std::vector<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>, std::allocator<std::unique_ptr<<unnamed>::StyleTree_Impl, std::default_delete<<unnamed>::StyleTree_Impl>>>> &, SfxStyleFamily, const weld::TreeIter *, bool, SfxViewShell *, SfxStyleSheetBasePool *)()
785                                       }
786                                   },
787                                   pParent, nullptr, /*bGoingToSetText*/ true);
788     
789         std::unique_ptr<weld::TreeIter> xChildParentIter = rBox.make_iterator(pParent);
790         if (!pParent)
>>>     CID 1633189:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "get_iter_first" without checking return value (as is done elsewhere 115 out of 120 times).
791             rBox.get_iter_first(*xChildParentIter);
792         else
793             rBox.iter_children(*xChildParentIter);
794         for (size_t i = 0; i < rTreeArray.size(); ++i)
795         {
796             if (i != 0)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DnRhp_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGty1-2FUKB4PBvJZ-2FFagYF2GLzXNWuSwRn6SvpKiGKcmBkCLfFe0HaGg215RdJALzAvYoKOYsipyLOLCUs3nygBd6qlc37cFecHWE3oRE32hDhcqbcgvA-2FmYwOu0TIFbUDIatENyv0vymyYEEp26-2BUS9dXKczJIg4QelSKqD0F-2BZz2I-3D