New Defects reported by Coverity Scan for LibreOffice

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
45 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1633350:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/shapeimporter.cxx: 210 in slideshow::internal::ShapeImporter::createShape(const com::sun::star::uno::Reference<com::sun::star::drawing::XShape> &, const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, std::basic_string_view<char16_t, std::char_traits<char16_t>>) const()


________________________________________________________________________________________________________
*** CID 1633350:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/slideshow/source/engine/shapes/shapeimporter.cxx: 210 in slideshow::internal::ShapeImporter::createShape(const com::sun::star::uno::Reference<com::sun::star::drawing::XShape> &, const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> &, std::basic_string_view<char16_t, std::char_traits<char16_t>>) const()
204         css::uno::Reference<css::drawing::XDrawPage> xPage = mxPage;
205         if (mbConvertingMasterPage && mbMasterPageObjectsOnly)
206         {
207             const XShapesEntry& rTop = maShapesStack.top();
208             css::uno::Reference<css::drawing::XDrawPage> xMasterPage(rTop.mxShapes, uno::UNO_QUERY_THROW);
209             if (xMasterPage.is())
>>>     CID 1633350:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "xMasterPage" is copied in a call to copy assignment "operator =", when it could be moved instead.
210                 xPage = xMasterPage;
211         }
212     
213         if( shapeType == u"com.sun.star.drawing.MediaShape" || shapeType == u"com.sun.star.presentation.MediaShape" )
214         {
215             // Media shape (video etc.). This is a special object


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3Dd4YJ_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt94j8ub02sVbLhFPNyft5gXaTa3nHLVXP90-2FXtVOpw14W76myJPxKupW7MBJ2snmv-2F6UWnx-2FygVzoY9oZl8ebMm-2BvyhL9F8KeBEYGZBCGeqAMuOfRgVw2VOkKowD2-2FmaizFQMstj5EsxBuY4oDyylaO4-2F13V12EiAvc2CGEeqJv0-3D