Subject: [PATCH] Request for review - Fix for Bug 103035: Improved Header/Footer dialog UI

[Hossein Nourikhah]

Hello Baludu,

Thank you for your interest in contributing to LibreOffice! Building 
LibreOffice from sources takes time, but after doing it a few times and 
dealing with possible issues, it will become much easier for you. 
LibreOffice is a complex software, and while developers try to improve 
and simplify the build process continuously, it is not always 
straightforward. But, anyway you have passed this step.

The next step is to understand the bug report to know the requirements, 
and then do the actual C++ development. Are you sure that you have read 
all the details of the bug report, described in all the comments? The 
bug report has 12 comments, and in this specific bug, you should read 
all of them to understand the requirements:

UI: Changing text formatting in Header/Footer dialog can be confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=103035

The above bug is categorized as a difficulty interesting EasyHack. This 
category is assigned by LibreOffice developers, indicating that this is 
NOT a trivial bug, that for example, you can fix it by adding a single 
character to the source code.

Therefore, please revise your submission, and always test locally to 
make sure your changes actually fix the issue. This submission does not.

Also, please note that you should not create multiple submissions for 
the same EasyHack. By keeping the Change-Id as it is assigned first 
time, all your new submissions for the same bug fall inside the same 
Gerrit page as new patch sets. Also, if CI build fails for some reason, 
either related to your code or not, the solution is not sending that 
again with a different Change-Id. If the failure is related to your 
patch, it is expected that you fix your submission and send a new patch 
set in the same Gerrit page, and if it is CI's fault, it is possible to 
resume or re-trigger the build. Therefore, please avoid creating 
multiple submissions for the same issue.

Regards,
Hossein

On 15.04.2025 05:35, Baludu Vamsi wrote:
> Hi all,
> 
> I’ve submitted a patch for Bug 103035 that improves the
> Header/Footer dialog UI related to text formatting in LibreOffice
> Calc.
> 
> Gerrit link: https://gerrit.libreoffice.org/c/core/+/184177
> 
> Just to share a bit — before this patch, I tried fixing three other
> bugs. Even though I wrote code that looked correct to me, I couldn’t
> get them to build locally. Still, I submitted those patches, and while
> Jenkins verified a few, most weren’t, and I ended up with several
> patchsets and abandoned attempts.
> 
> After all that, I decided to start fresh. I deleted the entire
> LibreOffice source, rebuilt everything cleanly from scratch, and then
> worked on this bug. This time, I was able to build successfully, test
> the fix locally, and get it verified by Jenkins too.
> 
> This process took around three days of continuous effort, and I’d be
> really grateful if someone could take a look and review this patch.
> 
> Thanks a lot in advance!
> 
> Best regards,
> Vamsi Baludu

-- 
Hossein Nourikhah, Ph.D., Developer Community Architect
Tel: +49 30 5557992-65 | Email: hossein at libreoffice.org
The Document Foundation, Winterfeldtstraße 52, 10781 Berlin, DE
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: https://www.documentfoundation.org/imprint