Howto unit test for LOOKUP with external reference

Xisco Fauli xiscofauli at libreoffice.org
Thu Aug 7 12:33:18 UTC 2025


Hi Regina,

at this point in time, tests in CppunitTest_sc_subsequent_filters_test* 
are basically import tests loading sample files from different formats 
to check their content so I think it's fine to put it there. Probably 
CppunitTest_sc_subsequent_filters_test should be renamed to 
CppunitTest_sc_subsequent_import_test to make it clearer, same as the 
existing CppunitTest_sc_subsequent_export_test.

BTW, if you use relative paths in the target file then the test can be 
simplified. See my latest patchset in 
https://gerrit.libreoffice.org/c/core/+/188304.

Regards

On 4/8/25 9:08, Regina Henschel wrote:
> Hi Xisco,
>
> Regina Henschel schrieb am 02.08.2025 um 01:37:
>> Regina Henschel schrieb am 25.07.2025 um 11:18:
>>> Hi all,
>>>
>>> this is about bug 167582. The fix itself is in 
>>> https://gerrit.libreoffice.org/c/core/+/188304
>>> But currently without unit test.
>>
> [..]> So the problem of writing a unit test is still unsolved.
>>
>
> I think, I have now a solution for the unit test. I exchange the IRI 
> that are contained in the LOOKUP parameters with the IRI of the 
> current position of the file. At least that works locally. Jenkins is 
> pending.
>
> The test is currently in ScFiltersTest5. But I'm unhappy with that, 
> because the test is not about filters. Xisco, do you have a suggestion 
> where to put the test?
>
> Kind regards,
> Regina

-- 
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0



More information about the LibreOffice mailing list