<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div><br></div><div>Hi</div><div><br></div><blockquote type="cite"><div><span>As a new committer (thanks again for your confidence), I don't know yet all</span><br><span>the rules and I prefer to ask before breaking something.</span><br></div></blockquote>Asking is clearly better than breaking :-)<div><br><blockquote type="cite"><div><span>As it is for 5-2 branch, do they require review from someone else than me,</span><br><span>before they can be pushed? (commits were already reviewed for master by jan)</span><br></div></blockquote>Our review rules are described here (and how to add a patch to a branch):</div><div><a href="https://wiki.documentfoundation.org/Development/Branches">https://wiki.documentfoundation.org/Development/Branches</a></div><div>Your patches are fixes to a X-Y branch, so no further review required.</div><div><br></div><div>Letting the patch linger a couple of days in gerrit is not a demand, but gives others a chance to comment, therefore highly recommended.</div><div><br></div><div>Your patches has been lingering, so go ahead and do your first merge,</div><div><br></div><div><blockquote type="cite"><div><span></span><span>Thanks for your help.</span><br></div></blockquote>Thanks for your work.</div><div><br></div><div>rgds</div><div>jan i<br><blockquote type="cite"><div><span></span></div></blockquote></div></body></html>