<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div><br></div><div><br>On 21 Jun 2016, at 13:03, Christian Lohmaier <<a href="mailto:lohmaier@googlemail.com">lohmaier@googlemail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span>On Sun, Jun 19, 2016 at 9:07 AM, jan iversen</span><br><span><<a href="mailto:jani@documentfoundation.org">jani@documentfoundation.org</a>> wrote:</span><br><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>As a new committer (thanks again for your confidence), I don't know yet all</span><br></blockquote><blockquote type="cite"><span>the rules and I prefer to ask before breaking something.</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Asking is clearly better than breaking :-)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>As it is for 5-2 branch, do they require review from someone else than me,</span><br></blockquote><blockquote type="cite"><span>before they can be pushed? (commits were already reviewed for master by jan)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Our review rules are described here (and how to add a patch to a branch):</span><br></blockquote><blockquote type="cite"><span><a href="https://wiki.documentfoundation.org/Development/Branches">https://wiki.documentfoundation.org/Development/Branches</a></span><br></blockquote><blockquote type="cite"><span>Your patches are fixes to a X-Y branch, so no further review required.</span><br></blockquote><span></span><br><span>Only in beta phase does a x-y branch not require review. after that it</span><br><span>needs one review.</span><br></div></blockquote><div><br></div>Maybe the text should be corrected in our wiki:<div><ul style="line-height: 1.5em; margin: 0.3em 0px 0px 1.6em; padding: 0px; list-style-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAANAQMAAABb8jbLAAAABlBMVEX///8AUow5QSOjAAAAAXRSTlMAQObYZgAAABNJREFUCB1jYEABBQw/wLCAgQEAGpIDyT0IVcsAAAAASUVORK5CYII=);"><li style="margin-bottom: 0.1em;"><span style="background-color: rgba(255, 255, 255, 0);">No review required until the last beta</span></li></ul><div><br></div><div>which I read as no extra review is needed for a X-Y branch.</div><div><br></div><blockquote type="cite"><div><span></span><span>And as Stephan pointed out: Only bugfixes go in.</span><br></div></blockquote>And since this is a bugfix it should not be a problem ?</div><div><br></div><div>rgds</div><div>jan I.</div><div><br><blockquote type="cite"><div><span></span><br><span>ciao</span><br><span>Christian</span><br></div></blockquote></div></body></html>