<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div></div><div>Hi</div><div><br></div><div>We prefer patches to be submitted through gerrit, as it gives us a possibility to review them.</div><div><br></div><div>Have a look at:</div><div><a href="https://wiki.documentfoundation.org/Development/GetInvolved#Prepare_to_submit_patches">https://wiki.documentfoundation.org/Development/GetInvolved#Prepare_to_submit_patches</a></div><div><br></div><div>Apart from that, your patch changes the way the program works, by removing the try/catch clause, you pass exceptions to higher levels (callers of the function), and that is surely not a good idea.</div><div><br></div><div>rgds</div><div>jan I.</div><div><br></div><div><br>On 24 Jul 2016, at 20:04, slacka <<a href="mailto:lukebenes@hotmail.com">lukebenes@hotmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span>Can we trust MSVC 2015 unreachable code analysis like we with this similar</span><br><span>issue?</span><br><span><<a href="http://nabble.documentfoundation.org/New-C2220-warning-treated-as-error-MSVC-2015-build-failure-tc4187644.html#a4189119">http://nabble.documentfoundation.org/New-C2220-warning-treated-as-error-MSVC-2015-build-failure-tc4187644.html#a4189119</a>> </span><br><span></span><br><span>The patch below fixes the build:</span><br><span></span><br><span>diff --git a/comphelper/source/misc/threadpool.cxx</span><br><span>b/comphelper/source/misc/threadpool.cxx</span><br><span>index 6846f4b..6a335e0 100644</span><br><span>--- a/comphelper/source/misc/threadpool.cxx</span><br><span>+++ b/comphelper/source/misc/threadpool.cxx</span><br><span>@@ -72,17 +72,7 @@ public:</span><br><span> {</span><br><span> SAL_WARN("comphelper", "exception in thread worker while</span><br><span>calling doWork(): " << e.Message);</span><br><span> }</span><br><span>- try {</span><br><span>- delete pTask;</span><br><span>- }</span><br><span>- catch (const std::exception &e)</span><br><span>- {</span><br><span>- SAL_WARN("comphelper", "exception in thread worker while</span><br><span>deleting task: " << e.what());</span><br><span>- }</span><br><span>- catch (const css::uno::Exception &e)</span><br><span>- {</span><br><span>- SAL_WARN("comphelper", "exception in thread worker while</span><br><span>deleting task: " << e.Message);</span><br><span>- }</span><br><span>+ delete pTask;</span><br><span> pTag->onTaskWorkerDone();</span><br><span> }</span><br><span> }</span><br><span></span><br><span></span><br><span></span><br><span></span><br><span></span><br><span></span><br><span>--</span><br><span>View this message in context: <a href="http://nabble.documentfoundation.org/C2220-warning-treated-as-error-64-bit-MSVC-2015-tp4184053p4189213.html">http://nabble.documentfoundation.org/C2220-warning-treated-as-error-64-bit-MSVC-2015-tp4184053p4189213.html</a></span><br><span>Sent from the Dev mailing list archive at <a href="http://nabble.com">Nabble.com</a>.</span><br><span>_______________________________________________</span><br><span>LibreOffice mailing list</span><br><span><a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a></span><br><span><a href="https://lists.freedesktop.org/mailman/listinfo/libreoffice">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></span><br></div></blockquote></body></html>