<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> slaka wrote <blockquote type="cite"> <pre wrap="">We are only failing 3 individual tests. And we fail the same tests Excel fails. Instead of disabling all test for x86 Linux , why not disable or change the rounding accuracy of the individual tests? </pre> </blockquote> LO only seems to have problems only with numbers very close to approaching 1 i.e. 0.999999999999999 The results LO gives for 0.000000000000001 through to .99999999 appear to be consistent with what the Keisan online calculator returns at <a class="moz-txt-link-freetext" href="http://keisan.casio.com/exec/system/1180573197">http://keisan.casio.com/exec/system/1180573197</a>. Personally I would either <ol> <li>change the expected result to match what LO now returns;</li> <li>change the number so that it is not so close to 1 i.e. something like 0.999999</li> <li>introduce another test with a number approaching 0 i.e. 0.000000000000001 </li> </ol> Alex <div class="moz-cite-prefix">On 14/09/16 23:06, slacka wrote: </div> <blockquote cite="mid:1473890805029-4193577.post@n3.nabble.com" type="cite"> <pre wrap="">Eike Rathke-2 wrote </pre> <blockquote type="cite"> <pre wrap="">If you want to get a working build without disabling all checks then you can use <a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254">https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254</a> that disables the function tests for linux_x86 builds. However, if you'd find a general solution that does not involve disabling the tests that would be more than welcomed. Eike </pre> </blockquote> <pre wrap=""> We are only failing 3 individual tests. And we fail the same tests Excel fails. Instead of disabling all test for x86 Linux , why not disable or change the rounding accuracy of the individual tests? For example, CHIINV can be made to work with both x86, x86-64 and Excel by changing C8=ROUND(A8,3)=ROUND(B8,3) VDS can be made to work with x86, x86-64, and Excel by changing C11=ROUND(A11,10)=ROUND(B11,10) MINVERSE x86 and Excel get similar results. Unless there is some evidences we have the same bug in our x86 code as Excel, the test is invalid or the bug is with the x86-64 code. So shouldn’t we disable that individual test? Eike Rathke-2 wrote </pre> <blockquote type="cite"> <pre wrap="">So you actually *do* see it. Or only not in chiinv.fods? </pre> </blockquote> <pre wrap=""> Sorry I was not clear. MINVERSE is the first test to fail on my AMD desktop. CHIINV does fail but only when I run it manually. I assume the tests are not run sequentially. Are they? If they are something weird is going on and I can try disabling MINVERSE and VDS to see if that's enough for a successful build. -- View this message in context: <a class="moz-txt-link-freetext" href="http://nabble.documentfoundation.org/Test-File-sc-qa-unit-data-functions-fods-chiinv-fods-fails-with-Assertion-tp4192267p4193577.html">http://nabble.documentfoundation.org/Test-File-sc-qa-unit-data-functions-fods-chiinv-fods-fails-with-Assertion-tp4192267p4193577.html</a> Sent from the Dev mailing list archive at Nabble.com. _______________________________________________ LibreOffice mailing list <a class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/libreoffice">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </pre> </blockquote> </body> </html>