<div dir="ltr">Hey Jan,<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 14, 2016 at 1:32 PM, Jan Iversen <span dir="ltr"><<a href="mailto:jani@documentfoundation.org" target="_blank">jani@documentfoundation.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div style="overflow-wrap: break-word;">(RESENDING WITHOUT ATTACHMENTS)</div><div style="overflow-wrap: break-word;"><br></div><div style="overflow-wrap: break-word;"><br><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><br></div><div>2) xx-ide-integration</div><div>I have test with Xcode and vim, same result (clearly because error occurs during startup.</div><div><br></div><div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures"> make vim-ide-integration</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">make -j 8 -rs -f /Volumes/LIBREOFFICE/play/core<wbr>/Makefile.gbuild gbuildtojson</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">cd /Volumes/LIBREOFFICE/play/core && /Volumes/LIBREOFFICE/play/core<wbr>/bin/gbuild-to-ide --ide vim --make make</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">'NoneType' object has no attribute 'group'</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">Traceback (most recent call last):</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">  File "/Volumes/LIBREOFFICE/play/cor<wbr>e/bin/gbuild-to-ide", line 1656, in <module></span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">    gbuildparser = GbuildParser(args.makecmd).par<wbr>se()</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">  File "/Volumes/LIBREOFFICE/play/cor<wbr>e/bin/gbuild-to-ide", line 185, in parse</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">    lib = self.__lib_from_json(json.load<wbr>(f))</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">  File "/Volumes/LIBREOFFICE/play/cor<wbr>e/bin/gbuild-to-ide", line 136, in __lib_from_json</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">    GbuildParser.libpattern.match(<wbr>os.path.basename(json['MAKEFIL<wbr>E'])).group(1),</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">AttributeError: 'NoneType' object has no attribute 'group'</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">Makefile:413: recipe for target 'vim-ide-integration' failed</span></div><div style="margin:0px;font-size:11px;line-height:normal;font-family:menlo;background-color:rgb(255,255,255)"><span style="font-variant-ligatures:no-common-ligatures">make: *** [vim-ide-integration] Error 1</span></div></div><div><span style="font-variant-ligatures:no-common-ligatures"><br></span></div><div><span style="font-variant-ligatures:no-common-ligatures">I ran it in my debugger and the file in question is  </span>'/workdir/GbuildToJson/Librar<wbr>y/libscqahelper.dylib’ which has ‘“MAKEFILE": "'/Volumes/LIBREOFFICE/play/co<wbr>re/sc/CppunitTest_sc_ucalc.mk’<wbr>”’ (see attachment <span style="font-family:menlo;font-size:11px;background-color:rgb(255,255,255)">GbuildToJson.tgz).</span></div><div><span style="font-family:menlo;font-size:11px;background-color:rgb(255,255,255)"><br></span></div><div><span style="font-family:menlo;font-size:11px;background-color:rgb(255,255,255)"><br></span></div><div><span style="font-family:menlo;font-size:11px;background-color:rgb(255,255,255)">The first problem, seems not to have a serious effect (the json files are identical between first and second run), but the second one means no </span><font face="Menlo"><span style="font-size:11px">ide-integration</span></font></div><div><font face="Menlo"><span style="font-size:11px"><br></span></font></div><div><font face="Menlo"><span style="font-size:11px">I look forward to hear your advice, my intention is currently to keep testing/correcting this until I have an acceptable solution on mac and windows, then that can be used as base for the perl removal and busybox integration.</span></font></div><div><font face="Menlo"><span style="font-size:11px"><br></span></font></div><div><font face="Menlo"><span style="font-size:11px">rgds</span></font></div><div><font face="Menlo"><span style="font-size:11px">jan I.</span></font></div><div><font face="Menlo"><span style="font-size:11px"><br></span></font></div><div><br></div><div></div><br></div></div></blockquote></div><br><br></div><div class="gmail_extra">So this is related to my patch bringing the unit tests into gbuildtojson. Sadly I can not reproduce it but already had another person with the same problem and forwarded my analysis to Björn. Somehow the makefiles info is mixed up at some point but I was unable to figure out when and why. IF you need a quick way to continue your work you can revert <a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=ee8057caaa26dcddbf80b1e0a2f02d250089d1e3">https://cgit.freedesktop.org/libreoffice/core/commit/?id=ee8057caaa26dcddbf80b1e0a2f02d250089d1e3</a> which should "fix" the problem.<br><br></div><div class="gmail_extra">Obviously a correct fix would be helpful and having the tests in gbuildtojson is a useful addition.<br><br></div><div class="gmail_extra">Regards,<br></div><div class="gmail_extra">Markus<br></div></div>