<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body smarttemplateinserted="true" bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
On 12/30/2016 2:56 PM, Filippo giacchè wrote:<br>
</div>
<blockquote cite="mid:CACLChT7KeAHHDw4Vp+MbNBZo7u+rnESyiWecLT=FGYZ1-ngTBA@mail.gmail.com" type="cite">
<div dir="ltr">I m trying to optimize ScInterpreter::ScGCD and ScInterpreter::ScLCM (in <span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">core</a><span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core/sc" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">sc</a><span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core/sc/source" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">source</a><span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core/sc/source/core" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">core</a><span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core/sc/source/core/tool" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">tool</a><span style="font-size:medium;color:rgb(0,0,0);font-family:monospace">/</span><a moz-do-not-send="true" href="http://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr5.cxx" style="font-size:medium;color:rgb(16,88,2);text-decoration:none;font-family:monospace">interpr5.cxx</a>)
as mentioned in bug tdf#89387..
<div>From what I understood , these function are not optimal in the matrix case (evenif the algorithms look good in my opinion) and need to be changed. So my question is how can I do it? If I create function in /core/sc/source/core/tool/ScMatrix.cxx that take
as input a matrix and retuns the GCD(or LCM) I'll do ok?or is not the right way to proceed? thanks ,<span style="background-color:rgb(252,252,255);color:rgb(20,20,20);font-family:verdana,arial,tahoma,calibri,geneva,sans-serif;font-size:13.3333px">I welcome
any advice that you can give me.</span></div>
</div>
</blockquote>
<br>
I would suggest you to suggest your vision as a change posted to gerrit for review, and let others to discuss the implementation: that could be much more productive IMO.<br>
If I'm wrong, I hope others will correct me.<br>
<br>
<div class="moz-signature">-- <br>
Best regards,<br>
Mike Kaganski</div>
<span class="st4cursor"></span>
</body>
</html>