<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><span></span></div><div><div>Hi all,</div><div><br></div><div>As I'm researching my book on the guts of LibreOffice, I notice that tools predates the SAL. In fact it's a bit of a hodge-lodge of files, many of which look like they should probably migrated into other modules.</div><div><br></div><div>I cleaned up ErrorHandler, but I thought I'd ask about the other headers here:</div><div><br></div><div>- b3dtrans.hxx - I'm assuming the b3d bit means basegfx 3D transformations. I've submitted <a href="https://gerrit.libreoffice.org/#/c/37030/">https://gerrit.libreoffice.org/#/c/37030/</a> to move it into basegfx but unfortunately it's failing o Windows and I don't currently have a working system to determine why the linker is erroring out.</div><div><br></div><div>- bigint.hxx and fract.hxx - seems to be more appropriate to the sal module, possibly the RTL? Great to get thoughts of others on this one</div><div><br></div><div>- color.hxx and colordata.hxx - should that migrate to basegfx also?</div><div><br></div><div>- gen.hxx - includes Pair (shouldn't that be deprecated to std::pair?), Point, Size, Range, Selection and Rectangle</div><div>- poly.hxx - polygons</div><div>- line.hxx - lines</div><div><br></div><div>gen.hxx, lines.hxx and poly.hxx all are drawing primitives, wouldn't these be better off in basegfx?</div><div><br></div><div>- config.hxx - where would this go? I was thinking the RTL, but it also seems like something the VLC might do...</div><div><br></div><div>- contr.hxx - seems better suited in the svx module...</div><div><br></div><div>- cpuid.hxx - checks for SSE2 support, surely something for the SAL?</div><div><br></div><div>- time.hxx, date.hxx, datetime.hxx and datetimeutils.hxx - these all seem to be better suited to the SAL, and actually should we consider moving to chrono?</div><div><br></div><div>- debug.hxx and diagnose_ex.hxx - seems more suited to the RTL...</div><div><br></div><div>-extendApplicationEnvironment - seems to be a candidate for the OSL...</div><div><br></div><div>- fldunit.hxx and fontenum.hxx - both seems to be more appropriate in the VCL</div><div><br></div><div><div><span style="background-color: rgba(255, 255, 255, 0);">There are quite a few headers, but as you can see most look to be more appropriately moved to another module. This would help streamline our module dependencies...</span></div><div><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div><span style="background-color: rgba(255, 255, 255, 0);">Thoughts?</span></div></div><div><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div><span style="background-color: rgba(255, 255, 255, 0);">Chris</span></div><div><br></div><div><br><div>Sent from my iPhone</div></div> </div></body></html>