<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
As I put on the gerrit patch, I give up with this patch because:<br>
- it's too complicated to modify the patch : the patching part was
working on my Mac and it fails to apply on Jenkins Mac<br>
- sse4 pb.
Even if it builds, LO may crash on pc which aren't compatible with
sse4<br>
<br>
Julien<br>
<br>
On 12/05/2017 14:33, marius adrian popa wrote:<br>
</div>
<blockquote
cite="mid:CAPv8svUjQzEDxrpYZ5LuqoGr+XnveZka7qK83+oyW+tcMJEnhw@mail.gmail.com"
type="cite">
<div dir="ltr">Also
in firebird/extern/cloop/src/tests/test1/CTest.c
<div><br>
<div>related to this patch </div>
<div><a moz-do-not-send="true"
href="https://gerrit.libreoffice.org/#/c/37488/6/external/firebird/firebird-macosx.patch.1">https://gerrit.libreoffice.org/#/c/37488/6/external/firebird/firebird-macosx.patch.1</a><br>
<div><br>
</div>
<div>
<div>these lines and changes are still needed for osx <span class="gmail-Apple-tab-span" style="white-space:pre"> </span></div>
<div> </div>
<div> #include "CalcCApi.h"</div>
<div>-#include <malloc.h></div>
<div>+#include <stdlib.h></div>
<div> #include <stdio.h></div>
</div>
<div><br>
</div>
<div>now build fails <a moz-do-not-send="true"
href="https://ci.libreoffice.org/job/lo_gerrit/11317/Config=macosx_clang_dbgutil/">https://ci.libreoffice.org/job/lo_gerrit/11317/Config=macosx_clang_dbgutil/</a></div>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, May 12, 2017 at 1:10 PM, Tomaž
Vajngerl <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:quikee@gmail.com" target="_blank">quikee@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span class=""><br>
On Fri, May 12, 2017 at 11:05 AM, marius adrian popa <<a
moz-do-not-send="true" href="mailto:mapopa@gmail.com">mapopa@gmail.com</a>>
wrote:<br>
> Known issue in Firebird 3.0.x<br>
><br>
> <a moz-do-not-send="true"
href="http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXFLAGS-in-3-0-on-linux-td4645224.html"
rel="noreferrer" target="_blank">http://firebird.1100200.n4.<wbr>nabble.com/std-c-11-added-to-<wbr>CXXFLAGS-in-3-0-on-linux-<wbr>td4645224.html</a><br>
><br>
> introduced by this commit<br>
><br>
> <a moz-do-not-send="true"
href="https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d"
rel="noreferrer" target="_blank">https://github.com/<wbr>FirebirdSQL/firebird/commit/<wbr>52d9a05a0f3d</a><br>
><br>
<br>
</span>They would need to add something like "%/CRC32C.o:
COMMON_FLAGS +=<br>
-msse4" to prefix.darwin too (clang should have compatible
switches)<br>
<br>
For Windows It is complicated as it depends if the
particular VS<br>
version supports the instructions or not, but you need to
add some<br>
compile switch too...<br>
<br>
That's only for compiler - in addition you also need
run-time<br>
detection, but I see this is already covered by
SSE4_2Supported()<br>
method.<br>
<br>
Regards, Tomaž<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>