<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2017-11-06 9:58 GMT+01:00 Stephan Bergmann <span dir="ltr"><<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Looking at the surrounding code<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
// Get redline info.<br>
boost::property_tree::ptree aTree;<br>
char* pJSON = pDocument->m_pDocumentClass->g<wbr>etCommandValues(pDocument, ".uno:AcceptTrackedChanges");<br>
std::stringstream aStream(pJSON);<br>
free(pJSON);<br>
CPPUNIT_ASSERT(!aStream.str().<wbr>empty());<br>
boost::property_tree::read_jso<wbr>n(aStream, aTree);<br>
// Make sure that pressing a key creates exactly one redline.<br>
CPPUNIT_ASSERT_EQUAL(static_ca<wbr>st<size_t>(1), aTree.get_child("redlines").si<wbr>ze());<br>
</blockquote>
<br>
what's the binary content of that "char* pJSON" stream? If that's still intact, then it's apparently boost::property_tree::read_jso<wbr>n that's breaking things. And if that's already garbled, then it's apparently the producer side of that pDocument->m_pDocumentClass->g<wbr>etCommandValues (whatever that is) that is breaking it and needs further investigation.<div class="gmail-HOEnZb"><div class="gmail-h5"><br></div></div></blockquote><div>I checked the read_json function and it was indeed rewritten in between the boost versions on the distro (and there were some comments about unicode support). So I had updated the boost function (basically to use latest boost code) in my testing repo and it still fails:</div><div><pre id="gmail-log_space" style="margin:0px 10px;padding:2px 3px;border:1px dotted rgb(102,153,0);outline:0px;font-size:10.4px;background:rgb(246,246,246);color:rgb(51,51,51);overflow-x:auto;white-space:pre-wrap;word-wrap:break-word;line-height:15.6px">[ 6427s] /home/abuild/rpmbuild/BUILD/libreoffice-5.4.2.2/desktop/qa/desktop_lib/test_desktop_lib.cxx:1660:DesktopLOKTest::testRedlineWriter
[ 6427s] equality assertion failed
[ 6427s] - Expected: Insert “t”
[ 6427s] - Actual : Insert “tâ€
</pre></div><div><br></div><div> FWIW I enabled it on the OBS so the full build log is tracked here:</div><div><a href="https://build.opensuse.org/package/live_build_log/LibreOffice:Factory/libreoffice/openSUSE_Leap_42.3/x86_64">https://build.opensuse.org/package/live_build_log/LibreOffice:Factory/libreoffice/openSUSE_Leap_42.3/x86_64</a><br></div><div><br></div><div>Any idea how to check the getCommandValues behaviour if it is the proper one?</div><div><br></div><div>Cheers</div><div><br></div><div>Tom</div></div></div></div>