<div dir="ltr">Hi Stephan,<div><br></div><div>I was how added this activex test to the source. First I added it to subsequent_test because I don't want it to run by make <module>, but then I realized that there is also the slowchecks, which are not run by make <module>, but run by top level make. It has the same dependency as other filters test in sd.</div><div><br></div><div>Best Regards,</div><div>Tamás</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-11-13 15:43 GMT+01:00 Stephan Bergmann <span dir="ltr"><<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 11/13/2017 11:54 AM, Tamás Zolnai wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
commit 0c5eda9876f353e0516171fec67568<wbr>643f24c5b6<br>
Author: Tamás Zolnai <<a href="mailto:tamas.zolnai@collabora.com" target="_blank">tamas.zolnai@collabora.com</a>><br>
Date: Mon Nov 13 10:13:13 2017 +0100<br>
<br>
Let's have activex control test also a slowcheck test<br>
Change-Id: I55f8f0ca9478e676832ebbb08e98d<wbr>bd1cf0fa4fc<br>
Reviewed-on: <a href="https://gerrit.libreoffice.org/44666" rel="noreferrer" target="_blank">https://gerrit.libreoffice.org<wbr>/44666</a><br>
Tested-by: Jenkins <<a href="mailto:ci@libreoffice.org" target="_blank">ci@libreoffice.org</a>><br>
Reviewed-by: Tamás Zolnai <<a href="mailto:tamas.zolnai@collabora.com" target="_blank">tamas.zolnai@collabora.com</a>><br>
<br>
diff --git a/sd/Module_sd.mk b/sd/Module_sd.mk<br>
index becd4528e81f..59f792a78037 100644<br>
--- a/sd/Module_sd.mk<br>
+++ b/sd/Module_sd.mk<br>
@@ -37,6 +37,7 @@ $(eval $(call gb_Module_add_slowcheck_target<wbr>s,sd,\<br>
CppunitTest_sd_filters_test \<br>
CppunitTest_sd_misc_tests \<br>
CppunitTest_sd_html_export_tes<wbr>ts \<br>
+ CppunitTest_sd_activex_control<wbr>s_tests \<br>
))<br>
endif<br>
@@ -56,7 +57,6 @@ $(eval $(call gb_Module_add_screenshot_targe<wbr>ts,sd, \<br>
$(eval $(call gb_Module_add_subsequentcheck_<wbr>targets,sd,\<br>
JunitTest_sd_unoapi \<br>
- CppunitTest_sd_activex_control<wbr>s_tests \<br>
))<br>
# vim: set noet sw=4 ts=4:<br>
</blockquote>
<br>
"Subsequent checks" were originally introduced to work around dependency issues: Those tests depended on the instdir (or its equivalent, back then) installation set being fully populated, so that those tests (mostly the infamous qadevOOo-style JunitTests, which spawn a full soffice process) could expect everything to be available without specifying full dependencies. (Where specifying the full dependencies would not even have been possible in all cases, IIRC.)<br>
<br>
I am not sure how much of that is still relevant, what (if any) implicit dependencies a subsequentcheck can still implicitly rely on. However, be careful when moving a test from subsequentcheck to somewhere else. It might still carry such implicit dependencies.<br>
______________________________<wbr>_________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.<wbr>org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/libreoffice" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/libreoffice</a><br>
</blockquote></div><br></div>