<?xml version="1.0" encoding="utf-16"?>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css"><![CDATA[#x1ed12467a12a4162875fdfdbe3cfe49c{
font-family:Tahoma;
font-size:12pt;
}#xba05d82ec9f6409dbd887cb138e1b38c{
font-family:Tahoma;
font-size:12pt;
}#xb20ca0f2522d41ea81d7c1029e7b56cb{
font-family:Tahoma;
font-size:12pt;
}#xeb9e962972ed4495bea02454d709b17d{
font-family:Tahoma;
font-size:12pt;
}#x08a4b77a793e4a8b8102a6b96ebe9985{
font-family:Tahoma;
font-size:12pt;
}#xa7df6074d5d64cbb94faea9d2823391f{
font-family:Tahoma;
font-size:12pt;
}#x14a8e7e033a046299cb269eb8adcb721 blockquote.cite{
margin-left:5px;
margin-right:0px;
padding-left:10px;
padding-right:0px;
border-left-width:1px;
border-left-style:solid;
border-left-color:#CCC;
}
#x14a8e7e033a046299cb269eb8adcb721 blockquote.cite2{
margin-left:5px;
margin-right:0px;
padding-left:10px;
padding-right:0px;
border-left-width:1px;
border-left-style:solid;
border-left-color:#CCC;
margin-top:3px;
padding-top:0px;
}
#x14a8e7e033a046299cb269eb8adcb721{
font-family:Tahoma;
font-size:12pt;
}]]><!--blockquote.cite
{margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right: 0px; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204);}
blockquote.cite2
{margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right: 0px; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 3px; padding-top: 0px;}
body
{font-family: Tahoma; font-size: 12pt;}
--></style>
</head>
<body>
<div>I tried, and got single redline with all my text.</div>
<div>Such case like typing new text is cared by sw::DocumentRedlineManager::AppendRedline, which has lengthy code for any possible situation (like typing inside deleted text, adding to existing redline, etc.) It also calls <span style="font-size: 12pt;">CompresRedlines
at the end, but many "compressions" are done by </span><span style="font-size: 12pt;">sw::DocumentRedlineManager::AppendRedline, so </span><span style="font-size: 12pt;">CompresRedlines doesn't do much</span></div>
<div><span style="font-size: 12pt;"><br>
</span></div>
<div>I think that the best solution for bug in question is to remove call to <span style="font-size: 12pt;">CompresRedlines from Undo/Redo. So Undo/Redo won't compress redlines and change indexes. </span></div>
<div id="xeb9e962972ed4495bea02454d709b17d">
<div>
<div><span style="font-size: 12pt;">I don't like to change </span><span style="font-size: 12pt;">CompresRedlines as it called by</span><span style="font-size: 12pt;"> </span><span style="font-size: 12pt;">AppendRedline and from several other places.</span></div>
</div>
<div><span style="font-size: 12pt;">For me such solution can be safest. </span></div>
<div><span style="font-size: 12pt;"><br>
</span></div>
<div><span style="font-size: 12pt;">PS Its funny, that if you type some text in single paragraph with change tracking = ON, you'll get new redline every single minute, even if you type continuously :-) This is by design, as </span><span style="font-size: 12pt;">AppendRedline
calls </span><span style="font-size: 12pt;">CanCombine which only allows combining those text, which has been typed during single minute (<a href="https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/DocumentRedlineManager.cxx#861">https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/DocumentRedlineManager.cxx#861</a>)</span></div>
</div>
<div><br>
</div>
<div>------ Исходное сообщение ------</div>
<div>От: "Miklos Vajna" <<a href="mailto:vmiklos@collabora.co.uk">vmiklos@collabora.co.uk</a>></div>
<div>Кому: "libreoffice@lists.freedesktop.org" <<a href="mailto:libreoffice@lists.freedesktop.org" style="">libreoffice@lists.freedesktop.org</a>></div>
<div>Отправлено: 08.01.2018 19:22:13</div>
<div>Тема: Re: Bug 83260</div>
<div><br>
</div>
<div id="xfdb8e9e04c7c4dd" class="plain">
<blockquote cite="20180108092213.dicmshrlbyc5mrw5@collabora.co.uk" type="cite" class="cite2">
<tt style="word-wrap:break-word">
<div>Hi,</div>
<div> </div>
<div>On Sat, Jan 06, 2018 at 01:20:05AM +0000, Yemelyanenko Fyodor <<a href="mailto:fyodor_e@hotmail.com">fyodor_e@hotmail.com</a>> wrote:</div>
<blockquote type="cite" class="cite">
<div> Now I’m investigating CompresRedlines further. I think it can be</div>
<div> changed so it merges only two neighbor redlines in the same node and</div>
<div> not merge cross-node. Or maybe it should be completely removed, as it</div>
<div> only merges redlines if they’ve been created in the same minute!</div>
<div> (<a href="https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/docredln.cxx#946">https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/docredln.cxx#946</a>)</div>
<div> So chances that two redlines will be merged are very low.</div>
</blockquote>
<div> </div>
<div>Did you try typing "asdf" into a document without that merging enabled?</div>
<div>I think 4 redlines are created without this "merge changes from the same</div>
<div>minute" mechanism.</div>
<div> </div>
<div>Regards,</div>
<div> </div>
<div>Miklos</div>
</tt></blockquote>
</div>
</body>
</html>