<?xml version="1.0" encoding="utf-16"?> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css"><![CDATA[#xea3cd535eaa74dbdae53e70ef0f12364{ font-family:'Segoe UI'; font-size:12pt; color:#000; margin-left:0px; margin-right:8px; background-color:#FFF; } #xea3cd535eaa74dbdae53e70ef0f12364 blockquote{ display:none; } #xea3cd535eaa74dbdae53e70ef0f12364 p.MsoNormal{ margin:0cm 0cm 0.0001pt; font-size:12pt; font-family:'Times New Roman',serif; } #xea3cd535eaa74dbdae53e70ef0f12364 a:link{ color:blue; text-decoration:underline; } #xea3cd535eaa74dbdae53e70ef0f12364 a:visited{ color:purple; text-decoration:underline; } #xea3cd535eaa74dbdae53e70ef0f12364 div.WordSection1{ page:WordSection1; }]]></style> </head> <body> <div> <div id="xea3cd535eaa74dbdae53e70ef0f12364"> <div lang="RU" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span class="SpellE"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">Sadly</span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"> <span class="SpellE">removing</span> <span class="SpellE">call</span> <span class="SpellE"> to</span> <span class="SpellE">CompresRedlines</span> <span class="SpellE">is</span> <span class="SpellE">not</span> <span class="SpellE">good</span> <span class="SpellE"> solution</span>…<o:p xmlns:o="#unknown"></o:p></span></p> <p class="MsoNormal"><span class="SpellE"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">AppendRedlines</span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"> <span class="SpellE">still</span> <span class="SpellE">calls</span> <span class="SpellE"> CompresRedlines</span> and <span class="SpellE">CompresRedlines</span> <span class="SpellE"> does</span> <span class="SpellE">it</span> <span class="SpellE">dirty</span> <span class="SpellE"> job</span> <span class="SpellE">by</span> <span class="SpellE">invalidating</span> <span class="SpellE">indexes</span>…<o:p xmlns:o="#unknown"></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"><o:p xmlns:o="#unknown"> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">I <span class="SpellE">prefer</span> <span class="SpellE">to</span> <span class="SpellE"> modify</span> <span class="SpellE">CompresRedlines</span> <span class="SpellE">so</span> <span class="SpellE">it</span> <span class="SpellE">only</span> <span class="SpellE"> compresses</span> <span class="SpellE">Redlines</span> <span class="SpellE">if</span> <span class="SpellE">they</span> <span class="SpellE">are</span> <span class="SpellE"> inside</span> <span class="SpellE">same</span> <span class="SpellE">node</span> and <span class="SpellE">disable</span> <span class="SpellE">cross-node compressions. As only same-minute redlines can be compressed this viewed as allowable solution.</span><o:p xmlns:o="#unknown"></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"><o:p xmlns:o="#unknown"> </o:p></span></p> <p class="MsoNormal"><span class="SpellE"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">With</span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"> <span class="SpellE">these</span> <span class="SpellE">modification</span> LO <span class="SpellE"> is</span> <span class="SpellE">stable</span> <span class="SpellE">when</span> <span class="SpellE"> autocreecting</span> and <span class="SpellE">Undo</span>/<span class="SpellE">Redo</span><o:p xmlns:o="#unknown"></o:p></span></p> <p class="MsoNormal"><span class="SpellE"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">Patch</span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"> <span class="SpellE">is</span> <span class="SpellE">here</span> </span><span lang="EN-US" style="font-size:10.0pt;font-family:"Lucida Console";mso-fareast-font-family:"Times New Roman";mso-bidi-font-family:"Lucida Console";mso-ansi-language:EN-US"><a href="https://gerrit.libreoffice.org/47686">https://gerrit.libreoffice.org/47686</a><o:p xmlns:o="#unknown"></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US"><o:p xmlns:o="#unknown"> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-ascii-theme-font:minor-latin;mso-hansi-theme-font:minor-latin;mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;color:#1F497D;mso-fareast-language:EN-US">Anyone (especially those with commit rights)are welcomed to review this patch.</span></p> </div> </div> </div> </div> <div><br> </div> <div>------ Исходное сообщение ------</div> <div>От: "Miklos Vajna" <<a href="mailto:vmiklos@collabora.co.uk">vmiklos@collabora.co.uk</a>></div> <div>Кому: "libreoffice@lists.freedesktop.org" <<a href="mailto:libreoffice@lists.freedesktop.org">libreoffice@lists.freedesktop.org</a>></div> <div>Отправлено: 10.01.2018 19:26:27</div> <div>Тема: Re: Bug 83260</div> <div><br> </div> <div id="x28c2a04021e5445" class="plain"> <blockquote cite="20180110092627.dhlxbwisg7eus2jj@collabora.co.uk" type="cite" class="cite2"> <tt style="word-wrap:break-word"> <div>Hi,</div> <div> </div> <div>On Tue, Jan 09, 2018 at 05:10:00AM +0000, Yemelyanenko Fyodor <<a href="mailto:fyodor_e@hotmail.com">fyodor_e@hotmail.com</a>> wrote:</div> <blockquote type="cite" class="cite"> <div> I think that the best solution for bug in question is to remove call to CompresRedlines from Undo/Redo. So Undo/Redo won't compress redlines and change indexes.</div> <div> I don't like to change CompresRedlines as it called by AppendRedline and from several other places.</div> <div> For me such solution can be safest.</div> </blockquote> <div> </div> <div>That sounds like a good approach, I was also confused how redlining and</div> <div>undo compresses the events.</div> <div> </div> <div>This would also ensure that the behavior of how to compress redline in</div> <div>saved documents is not changing, which is probably a good thing.</div> <div> </div> <blockquote type="cite" class="cite2"> <div> PS Its funny, that if you type some text in single paragraph with</div> <div> change tracking = ON, you'll get new redline every single minute, even</div> <div> if you type continuously :-) This is by design, as AppendRedline calls</div> <div> CanCombine which only allows combining those text, which has been</div> <div> typed during single minute</div> <div> (<a href="https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/DocumentRedlineManager.cxx#861">https://opengrok.libreoffice.org/xref/core/sw/source/core/doc/DocumentRedlineManager.cxx#861</a>)</div> </blockquote> <div> </div> <div>Yes, that's a known behavior, in the past I broke it and it created a</div> <div>new redline every second, that was not funny. ;-)</div> <div> </div> <div>Regards,</div> <div> </div> <div>Miklos</div> </tt></blockquote> </div> </body> </html>