<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><br><br><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>As it happens, in LibreOffice code, "#ifdef DEBUG" is 1:1 equivalent to "#if (OSL_DEBUG_LEVEL >= 2)", and the thought was that perhaps all instances of "#ifdef DEBUG" should be changed to that instead, to make it more clear that it is a rather rare way to build, that code inside "#ifdef DEBUG" is *not* compiled in a normal --enable-debug or --enable-dbgutil build, but one needs the much more rare case of increasing the dbglevel thing.</div><div><br></div><div>It has even been suggested in the past we should get rid of those dbglevel, or OSL_DEBUG_LEVEL, things, to make the configuration space smaller. It is quite enough (in my opinion) to have --enable-debug, --enable-dbgutil, --enable-symbols, --enable-assert-always-abort, and --enable-sal-log, that all have related but different meanings. Also --enable-release-build could be interpreted as being related. And I probably forgot some...</div></div></div></blockquote><div><br></div>Having fallen into this pitfall a couple of times and got a headache understanding why the code was not executed, I highly favor to at least change to OSL_DEBUG_LEVEL >= 2.<div><br></div><div>I am one of those who would like to remove the debug levels, but lately (spending far too much time in the internal UNO workings), I am a little afraid that we have a lot of bit rotten code waiting to become a problem. So doing this change in a branch would be wise.</div><div><br></div><div>rgds</div><div>jan I</div><div><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>Currently, when somebody loosely talks about "debug mode" vs "release mode" (as is common for people coming from a background of Visual Studio projects, for instance), it is fairly unclear what they actually mean. We should strive to make it clearer.</div><div><br></div><div>What you say "<span style="font-size:12.800000190734863px">make my own DEBUG build", what do you mean exactly?</span></div><div><br></div><div>--tml</div><div><br></div></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>LibreOffice mailing list</span><br><span><a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a></span><br><span><a href="https://lists.freedesktop.org/mailman/listinfo/libreoffice">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></span><br></div></blockquote></div></body></html>