<html><head></head><body>Tango actually got the remaining ICP s, or should at least. I will check it when back next Thursday.<br><br><div class="gmail_quote">On 12 August 2018 11:09:42 CEST, Maxim Monastirsky <momonasmon@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> I think you should use colibre *instead* of tango. My understanding<br> is<br></blockquote> <br> No, that looks too much Windows'ishy to me.<br></blockquote><br>Ah, OK. In this case it might make sense to do an upstream patch to<br>copy these icons to tango, as we already did for a lot of other icons<br>that were copied to tango from galaxy (see tdf#118123).<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> that colibre is at least as complete as tango, and is actively<br> maintained unlike tango. And tango isn't even part of the fallback<br></blockquote> <br> That is not 100% true, see my paste.<br> <br> For the desktop detection icon detection it is.<br></blockquote><br>The desktop detection code you cited is about defining the *preferred*<br>icon theme, not about "fallback" - which means what to do when the<br>requested theme isn't found. The fallback for a complete icon theme (as<br>opposed to an individual icon) is done like this:<br><br>/*static*/ OUString<br>IconThemeSelector::ReturnFallback(const std::vector<IconThemeInfo>&<br>installedThemes)<br>{<br> if (!installedThemes.empty()) {<br> return installedThemes.front().GetThemeId();<br> }<br> else {<br> return FALLBACK_ICON_THEME_ID;<br> }<br>}<br><br>... which means that it will return the first found theme, which might<br>or might not be tango. Imagine a case of a user running gnome or kde<br>(which have other defined themes in<br>IconThemeSelector::GetIconThemeForDesktopEnvironment), while having<br>only tango and colibre. It will get through the above code, and might<br>pick colibre as well, which is not what you want.<br><br>Maxim<br><br></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>