<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Forgot the link to the changes, here it is: <a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/#/c/74333/">https://gerrit.libreoffice.org/#/c/74333/</a> <div class="moz-cite-prefix">On 2019-06-20 5:01 p.m., Artur Neumann wrote: </div> <blockquote type="cite" cite="mid:16341a67-41a4-5031-174c-4d804cad7d0c@jankaritech.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> I've made some UI tests that open every dialog in calc, close it with the "close" or "cancel" button and if there is an "OK" button open it again and click the "OK" button These tests should simply make sure there are no crashes by opening/closing the dialogues and protect against regressions like <a class="moz-txt-link-freetext" href="https://bugs.documentfoundation.org/show_bug.cgi?id=120227" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=120227</a> <a class="moz-txt-link-freetext" href="https://bugs.documentfoundation.org/show_bug.cgi?id=125982" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=125982</a> <a class="moz-txt-link-freetext" href="https://bugs.documentfoundation.org/show_bug.cgi?id=125985" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=125985</a> I just wanted to have some feedback if picking those low-hanging fruits is a valid approach and worth the effort and CI time. If yes I could extend the tests by: <ol> <li>doing the same for writer, impress, etc.</li> <li>delete obsolete tests like uitest/calc_tests/about_test.py </li> <li>define preconditions for the "OK" click, e.g. input data into fields</li> <li>define assertion after the click on the "OK" button</li> </ol> Thoughts? Ideas? <pre class="moz-signature" cols="72">-- Artur Neumann Director/CTO Jankari Tech Pvt Ltd <a class="moz-txt-link-abbreviated" href="http://www.jankaritech.com" moz-do-not-send="true">www.jankaritech.com</a> Phone: +977 9806639223 Skype: artur.n. GitHub: <a class="moz-txt-link-freetext" href="https://github.com/individual-it" moz-do-not-send="true">https://github.com/individual-it</a></pre> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ LibreOffice mailing list <a class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/libreoffice">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></pre> </blockquote> <pre class="moz-signature" cols="72">-- Artur Neumann Director/CTO Jankari Tech Pvt Ltd <a class="moz-txt-link-abbreviated" href="http://www.jankaritech.com">www.jankaritech.com</a> Phone: +977 9806639223 Skype: artur.n. GitHub: <a class="moz-txt-link-freetext" href="https://github.com/individual-it">https://github.com/individual-it</a></pre> </body> </html>