<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Hello Artur,<br>
generally it looks useful, but please check first if such test
exists. For example bug 120227 is already covered by this test
<a class="moz-txt-link-freetext" href="https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/pageFormat/">https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/pageFormat/</a><a
href="https://bugs.documentfoundation.org/show_bug.cgi?id=123508">tdf123508</a>.py
.<br>
Please search first at opengrok, because uitests are quite slow
and we should avoid duplicity. For example from your test <br>
SearchDialog - lots of tests exists in directory <a
href="https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/search_replace/">/core/sc/qa/uitest/search_replace/</a><br>
InsertObjectChart - lots of tests exists in directory
/core/sc/qa/uitest/chart/<br>
FunctionDialog -
<a class="moz-txt-link-freetext" href="https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/calc_tests7/tdf123479.py">https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/calc_tests7/tdf123479.py</a><br>
etc.<br>
<br>
Please add your test to the new directory, see
<a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/#/c/72376/">https://gerrit.libreoffice.org/#/c/72376/</a> like an example<br>
Note: the tests runs in "gen" enviroment, so gtk3 bugs we cannot
test (<a class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=125982"
target="_blank">125982</a>, <a
class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=125985"
target="_blank">125985</a>)<br>
<a
href="https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/chart/"></a><br>
Best regards,<br>
Raal<br>
<br>
<br>
<br>
<br>
On 22. 06. 19 11:10, Markus Mohrhard wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAEDdEt7m2ex+jgvimo=K9M7Us7t4dXjgiBL0JJik6297ndgPeg@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">Hello Artur,<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Jun 21, 2019 at
12:06 PM Artur Neumann <<a
href="mailto:artur@jankaritech.com" moz-do-not-send="true">artur@jankaritech.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>Forgot the link to the changes, here it is: <a
class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://gerrit.libreoffice.org/#/c/74333/"
target="_blank" moz-do-not-send="true">https://gerrit.libreoffice.org/#/c/74333/</a><br>
</p>
<div class="gmail-m_8538954462530889681moz-cite-prefix">On
2019-06-20 5:01 p.m., Artur Neumann wrote:<br>
</div>
<blockquote type="cite">
<p>I've made some UI tests that open every dialog in
calc, close it with the "close" or "cancel" button and
if there is an "OK" button open it again and click the
"OK" button</p>
<p>These tests should simply make sure there are no
crashes by opening/closing the dialogues and protect
against regressions like <br>
<a
class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=120227"
target="_blank" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=120227</a><br>
<a
class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=125982"
target="_blank" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=125982</a><br>
<a
class="gmail-m_8538954462530889681moz-txt-link-freetext"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=125985"
target="_blank" moz-do-not-send="true">https://bugs.documentfoundation.org/show_bug.cgi?id=125985</a></p>
<p>I just wanted to have some feedback if picking those
low-hanging fruits is a valid approach and worth the
effort and CI time.<br>
</p>
</blockquote>
</div>
</blockquote>
<div><br>
</div>
<div>I think that in general it is a good idea. Depending on
how long it takes to execute the test we might need to think
about whether we can actually include the tests in a normal
make/make check or if they need to be treated differently.
Did you already have a chat with Raal who has been writing
tests for many bugs/dialogs already?<br>
</div>
<div> <br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<blockquote type="cite">
<p> </p>
<p>If yes I could extend the tests by:</p>
<ol>
<li>doing the same for writer, impress, etc.</li>
<li>delete obsolete tests like
uitest/calc_tests/about_test.py<br>
</li>
<li>define preconditions for the "OK" click, e.g.
input data into fields</li>
<li>define assertion after the click on the "OK"
button</li>
</ol>
</blockquote>
</div>
</blockquote>
<div><br>
</div>
<div>In general this sounds like a good idea. As mentioned it
might be good to have a chat with Raal who might have an
overview how far we are in opening all dialogs already.</div>
<div><br>
</div>
<div>Regards,</div>
<div>Markus<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<blockquote type="cite">
<ol>
</ol>
<p>Thoughts? Ideas?<br>
</p>
<pre class="gmail-m_8538954462530889681moz-signature" cols="72">--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
<a class="gmail-m_8538954462530889681moz-txt-link-abbreviated" href="http://www.jankaritech.com" target="_blank" moz-do-not-send="true">www.jankaritech.com</a>
Phone: +977 9806639223
Skype: artur.n.
GitHub: <a class="gmail-m_8538954462530889681moz-txt-link-freetext" href="https://github.com/individual-it" target="_blank" moz-do-not-send="true">https://github.com/individual-it</a></pre>
<br>
<fieldset
class="gmail-m_8538954462530889681mimeAttachmentHeader"></fieldset>
<pre class="gmail-m_8538954462530889681moz-quote-pre">_______________________________________________
LibreOffice mailing list
<a class="gmail-m_8538954462530889681moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org" target="_blank" moz-do-not-send="true">LibreOffice@lists.freedesktop.org</a>
<a class="gmail-m_8538954462530889681moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></pre>
</blockquote>
<pre class="gmail-m_8538954462530889681moz-signature" cols="72">--
Artur Neumann
Director/CTO
Jankari Tech Pvt Ltd
<a class="gmail-m_8538954462530889681moz-txt-link-abbreviated" href="http://www.jankaritech.com" target="_blank" moz-do-not-send="true">www.jankaritech.com</a>
Phone: +977 9806639223
Skype: artur.n.
GitHub: <a class="gmail-m_8538954462530889681moz-txt-link-freetext" href="https://github.com/individual-it" target="_blank" moz-do-not-send="true">https://github.com/individual-it</a></pre>
</div>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org"
target="_blank" moz-do-not-send="true">LibreOffice@lists.freedesktop.org</a><br>
<a
href="https://lists.freedesktop.org/mailman/listinfo/libreoffice"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></blockquote>
</div>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
LibreOffice is powered by a team of volunteers who mostly give their time for free.
We invite you to join as there are many ways to get involved including bugs triage,
marketing, UX, documentation, and of course developing - <a class="moz-txt-link-freetext" href="https://www.libreoffice.org/get-involved/">https://www.libreoffice.org/get-involved/</a></pre>
</body>
</html>