<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">I work on fix here:</div><div class="gmail_default" style="font-family:arial,sans-serif"><a href="https://gerrit.libreoffice.org/#/c/79663/">https://gerrit.libreoffice.org/#/c/79663/</a></div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Arkadiy Illarionov</div></div></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 26, 2019 at 1:12 PM Stephan Bergmann <<a href="mailto:sbergman@redhat.com">sbergman@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ever since <br>
<<a href="https://gerrit.libreoffice.org/plugins/gitiles/core/+/36c1c2c2754dda6e8d2b2802e3881465adaafbec%5E!/" rel="noreferrer" target="_blank">https://gerrit.libreoffice.org/plugins/gitiles/core/+/36c1c2c2754dda6e8d2b2802e3881465adaafbec%5E!/</a>> <br>
"Added GLOMenu and GLOActionGroup. Menu is published with actions (not <br>
working)", g_lo_action_group_init in vcl/unx/gtk/gloactiongroup.cxx <br>
contains a call<br>
<br>
>     group->priv = G_TYPE_INSTANCE_GET_PRIVATE (group,<br>
>                                                  G_TYPE_LO_ACTION_GROUP,<br>
>                                                  GLOActionGroupPrivate);<br>
<br>
that GLib 2.62 (as seen on Fedora 31) now warns about:<br>
<br>
> [CXX] vcl/unx/gtk3/gtk3gloactiongroup.cxx<br>
> In file included from vcl/unx/gtk3/gtk3gloactiongroup.cxx:3:<br>
> vcl/unx/gtk3/../gtk/gloactiongroup.cxx:317:19: warning: G_ADD_PRIVATE [-W#pragma-messages]<br>
>     group->priv = G_TYPE_INSTANCE_GET_PRIVATE (group,<br>
>                   ^<br>
> /usr/include/glib-2.0/gobject/gtype.h:643:145: note: expanded from macro 'G_TYPE_INSTANCE_GET_PRIVATE'<br>
> #define G_TYPE_INSTANCE_GET_PRIVATE(instance, g_type, c_type)   ((c_type*) g_type_instance_get_private ((GTypeInstance*) (instance), (g_type))) GLIB_DEPRECATED_MACRO_IN_2_58_FOR(G_ADD_PRIVATE)<br>
>                                                                                                                                                 ^<br>
> /usr/include/glib-2.0/glib/gversionmacros.h:831:49: note: expanded from macro 'GLIB_DEPRECATED_MACRO_IN_2_58_FOR'<br>
> # define GLIB_DEPRECATED_MACRO_IN_2_58_FOR(f)   GLIB_DEPRECATED_MACRO_FOR(f)<br>
>                                                 ^<br>
> /usr/include/glib-2.0/glib/gmacros.h:990:38: note: expanded from macro 'GLIB_DEPRECATED_MACRO_FOR'<br>
> #define GLIB_DEPRECATED_MACRO_FOR(f) _GLIB_GNUC_DO_PRAGMA(GCC warning #f)<br>
>                                      ^<br>
> /usr/include/glib-2.0/glib/gmacros.h:988:33: note: expanded from macro '_GLIB_GNUC_DO_PRAGMA'<br>
> #define _GLIB_GNUC_DO_PRAGMA(x) _Pragma(G_STRINGIFY (x))<br>
>                                 ^<br>
> <scratch space>:57:6: note: expanded from here<br>
>  GCC warning "G_ADD_PRIVATE"<br>
>      ^<br>
> 1 warning generated.<br>
<br>
(And while Clang keeps that a warning even with -Werror, it causes a <br>
true error breaking the build when building with GCC and --enable-werror.)<br>
<br>
<<a href="https://developer.gnome.org/gobject/stable/gobject-Type-Information.html#G-TYPE-INSTANCE-GET-PRIVATE:CAPS" rel="noreferrer" target="_blank">https://developer.gnome.org/gobject/stable/gobject-Type-Information.html#G-TYPE-INSTANCE-GET-PRIVATE:CAPS</a>> <br>
states:  "G_TYPE_INSTANCE_GET_PRIVATE has been deprecated since version <br>
2.58 and should not be used in newly-written code.  Use G_ADD_PRIVATE <br>
and the generated your_type_get_instance_private() function instead"<br>
<br>
But I have no idea how to fix that.  So if anybody can clean it up, that <br>
would be great.  (Failing that, we can always add a sledgehammer<br>
<br>
> #define GLIB_DISABLE_DEPRECATION_WARNINGS<br>
<br>
near the top of vcl/unx/gtk/gloactiongroup.cxx, similar to what is done <br>
in <br>
<<a href="https://gerrit.libreoffice.org/plugins/gitiles/core/+/59f96e1736c14575aee7575e73b50e96cf467bb0%5E!/" rel="noreferrer" target="_blank">https://gerrit.libreoffice.org/plugins/gitiles/core/+/59f96e1736c14575aee7575e73b50e96cf467bb0%5E!/</a>> <br>
"While I could swear that it worked yesterday".)<br>
<br>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/libreoffice" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/libreoffice</a></blockquote></div></div>