<div>                Commented here: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8a82100c8274d3c0e6d8386116fe8c48543fc4c3<br>            </div>            <div class="yahoo_quoted" style="margin:10px 0px 0px 0.8ex;border-left:1px solid #ccc;padding-left:1ex;">                        <div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">                                <div>                    Le mardi 19 novembre 2019 à 11:22:49 UTC+1, Julien <serval2412@yahoo.fr> a écrit :                </div>                <div><br></div>                <div><br></div>                <div><div id="yiv9537345306"><div><div>                Hi Michael<br clear="none"><br clear="none">There's no function "GetTextWidth" (or I missed it), so can't do this assertion.<br clear="none">See https://opengrok.libreoffice.org/xref/core/sw/source/core/text/portxt.cxx?r=7ade17fd#810<br clear="none"><br clear="none">Julien<br clear="none">            </div>            <div class="yiv9537345306yqt9604483568" id="yiv9537345306yqt60738"><div class="yiv9537345306yahoo_quoted" style="margin:10px 0px 0px 0.8ex;border-left:1px solid #ccc;padding-left:1ex;">                        <div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">                                <div>                    Le mardi 19 novembre 2019 à 11:12:24 UTC+1, Michael Stahl <mst@libreoffice.org> a écrit :                </div>                <div><br clear="none"></div>                <div><br clear="none"></div>                <div><div dir="ltr">On 19.11.19 09:20, Miklos Vajna wrote:<div class="yiv9537345306yqt9174265052" id="yiv9537345306yqtfd54773"><br clear="none">> Hi Julien,<br clear="none">> <br clear="none">> Oh sorry, I didn't realize this pattern is:<br clear="none">> <br clear="none">> SetWidth(GetHeight())<br clear="none">> SetHeight(GetHeight())<br clear="none">> <br clear="none">> I thought it's:<br clear="none">> <br clear="none">> SetWidth(GetHeight())<br clear="none">> SetHeight(GetWidth())<br clear="none">> <br clear="none">> With that in mind, the current code is just OK, the width of the<br clear="none">> checkbox portion is the same as its height, since it's a square (and<br clear="none">> that size depends on the font size).<br clear="none">> <br clear="none">> Perhaps add a comment explaining this to make it easier for the next<br clear="none">> person to understand. :-)</div><br clear="none"><br clear="none">even better: add an assertion that the width and the height are the <br clear="none">same, then you'll find out in case your assumption isn't true.<br clear="none"><br clear="none">assertions are executable documentation :)<div class="yiv9537345306yqt9174265052" id="yiv9537345306yqtfd24346"><br clear="none"></div></div></div>            </div>                </div></div></div></div></div>            </div>                </div>