<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Markus,<div class=""><br class=""></div><div class="">about the size_t changes. Most correct seams for me a solution to change all these to size_t and avoid casting, but that is a lot of work.</div><div class=""><br class=""></div><div class="">Let me know, if you need some kind of support.</div><div class=""><br class=""></div><div class="">Also, i saw, that you have not merges documentation termination for \n to \\n or c:\path to c:\\path.</div><div class=""><br class=""></div><div class="">The backslash is interpreted as command so you need to terminate it.</div><div class=""><br class=""></div><div class="">I have merged master from remote and new feature branch. So you can compare both to see, what patches are not yet merged.</div><div class=""><br class=""></div><div class="">Regards,</div><div class="">Florian</div><div class=""> <div><br class=""><blockquote type="cite" class=""><div class="">Am 30.09.2021 um 21:55 schrieb Markus Mohrhard <<a href="mailto:markus.mohrhard@googlemail.com" class="">markus.mohrhard@googlemail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div dir="ltr" class=""><div dir="ltr" class="">Hey Florian,<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard <<a href="mailto:markus.mohrhard@googlemail.com" target="_blank" class="">markus.mohrhard@googlemail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div dir="ltr" class="">Hey Florian,<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 28, 2021 at 5:59 PM Florian Becker <<a href="mailto:fb@vxapps.com" target="_blank" class="">fb@vxapps.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br class=""> <br class=""> i have patched the libcppunit 1.15.1 to modernize and use clang flags <br class=""> with highest flag settings. Hopefully you can integrate this patch <br class=""> inside master. <a href="https://github.com/VXAPPS/cppunit/tree/feature-modernize" rel="noreferrer" target="_blank" class="">https://github.com/VXAPPS/cppunit/tree/feature-modernize</a><br class=""> <br class=""> If you have suggestions, please let me know.<br class=""></blockquote><div class=""><br class=""></div><div class="">I'll have a look during the next few days and will let you know if I have any questions or comments</div></div></div></blockquote><div class=""><br class=""></div><div class="">Thanks for your patches. The summary is:</div><div class=""><br class=""></div><div class="">* first patch was used without modifications</div><div class="">* second patch was split up into smaller commits:</div><div class=""> * add [[noreturn]]</div><div class=""> * add override annotations</div><div class=""> * switch from throw to noexcept</div><div class=""> * remove semicolons</div><div class=""> * a complete removal of the old casting macros by me instead of your addition to the portability header</div><div class=""> * replace 0 with nullptr</div><div class=""> * disable a few simple compiler warnings</div><div class=""><br class=""></div><div class="">I have not yet taken the size_t changes as that part contains some bugs. I have already fixed one but want to have a second look and think about whether this is how we want to solve this problem.</div><div class="">I also had to remove all references to [[deprecated]] in this change as [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.<br class=""></div><div class=""><br class=""></div><div class="">* I'll have to think a bit about the third and fourth patch. If I merge them I'll let you know.</div><div class=""><br class=""></div><div class="">You can find the full code that I have pushed at:</div><div class=""><br class=""></div><div class=""><a href="https://git.libreoffice.org/cppunit/+log/refs/heads/master" class="">https://git.libreoffice.org/cppunit/+log/refs/heads/master</a></div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Markus<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div class="gmail_quote"><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Markus</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br class=""> Regards,<br class=""> Florian<br class=""> <br class=""> </blockquote></div></div> </blockquote></div></div> </div></blockquote></div><br class=""></div></body></html>