<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 13 Jun 2022 at 09:15, Stephan Bergmann <<a href="mailto:sbergman@redhat.com">sbergman@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/06/2022 18:06, <a href="mailto:scan-admin@coverity.com" target="_blank">scan-admin@coverity.com</a> wrote:<br>
> *** CID 1505368:  Performance inefficiencies  (PASS_BY_VALUE)<br>There's been a handful of such Coverity reports lately.  Doesn't it look <br>
like clang-tidy modernize-pass-by-value gives potentially poor advice <br>
here, but which we followed blindly in commits like <br>
<<a href="https://git.libreoffice.org/core/+/91fef4a47563451e0271784a14b471e4815729d1%5E!/" rel="noreferrer" target="_blank">https://git.libreoffice.org/core/+/91fef4a47563451e0271784a14b471e4815729d1%5E!/</a>> <br>
"clang-tidy modernize-pass-by-value in editeng"?<br>
<br></blockquote><div><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">We should just revert the stuff that coverity noticed, it's very much only a handful of places.</div><div class="gmail_default" style="font-family:tahoma,sans-serif"></div></div></div>