<div dir="ltr"><div>Hi Regina,<br></div><div><br></div><div>Sorry, I have vacation so I'm travelling again, but found some time to reply.<br></div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 11, 2023 at 6:59 AM Regina Henschel <<a href="mailto:rb.henschel@t-online.de" target="_blank">rb.henschel@t-online.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Tomaž,<br>
<br>
I have currently only 'RGBHex' and 'Theme' in my ODF proposal draft. And <br>
I have put the color-transformations separate from the definition of the <br>
base color (see attachment). That was my guess from the additions to the <br>
RelaxNG.<br>
Does integrating the color-transformation into my <style:enhanced-color> <br>
would better fit to your intentions? I could change that.<br></blockquote><div><br></div><div>Currently we have something like this example:</div><div><style:graphic-properties svg:stroke-color="#536dfe" draw:fill-color="#bbc5fe" ...></div><div> <loext:fill-color-theme-reference loext:type="accent1"><br> <loext:transformation loext:type="lummod" loext:value="4000" /><br> <loext:transformation loext:type="lumoff" loext:value="6000" /><br> </loext:fill-color-theme-reference><br> <loext:stroke-color-theme-reference ... ><br> ....<br> </loext:stroke-color-theme-reference><br> </style:graphic-properties></div><div><br></div><div>I thought to just change it to:<br><div><style:graphic-properties svg:stroke-color="#536dfe" draw:fill-color="#bbc5fe" ...></div><div> <loext:fill-complex-color loext:type="theme" loext:value="accent1"><br> <loext:transformation loext:type="lummod" loext:value="4000" /><br> <loext:transformation loext:type="lumoff" loext:value="6000" /><br> </loext:fill-complex-color><br> <loext:stroke-complexcolor ... ><br> ....<br> </loext:stroke-complex-color><br> </style:graphic-properties></div></div><div><br></div><div>Do we actually need <style:enhanced-color> element - couldn't we have it in the attributes of the parent element which would be fill-complexcolor, stroke-complex-color?</div><div>I think the transformations are fine where they are. Not sure the change would make any difference. How the change <br> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The ColorType 'CRGB' did not get support in the ODF TC right away, <br>
because it is also only a variant of RGB. The same would then apply to <br>
ColorType 'HSL'. They could be converted in the xmloff export filter.<br></blockquote><div><br></div><div>Yes, that makes sense. HSL makes sense in some cases (tcould be easier to think in HSL when you later change one of H, S or L values with a transform) , but not sure we would use that all that often.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Regarding ColorType 'System' and its 'SystemColorType', I don't see yet <br>
how this can be implemented well to ODF. It would mean to have a <br>
reference to a color table defined at the user or the user's system. And <br>
it is different from CSS4 <system-color> [2], so specifying by reference <br>
to CSS4 will not work.<br></blockquote><div><br></div><div>I think we don't need this for ODF - in OOXML we convert the colors using a fixed mapping function/table anyway. We don't ask the system (OS) for the colors.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
What is ColorType 'Palette' and 'Placeholder'? Is it something, that <br>
needs to be written to ODF markup?<br></blockquote><div><br></div><div>Regarding "Palette" it is the prstClr element in OOXML. Maybe I should rename it to "Preset" too. We don't need that in ODF I think. </div><div><br></div><div>"Placeholder" is needed in themes, but not theme colors. Placeholder is replaced by a theme (scheme) color, whatever one is defined by that theme link (IIRC). It's used mainly in the format scheme of a theme - so for themes for shapes. Would be good to define it now, even when we won't be really using it yet. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
We could<br>
> make create a UNO interface for that first and a wrapper, then use it at <br>
> all places where XThemeColor is used now, and also add it to the gradient.<br>
<br>
Having a UNO interface and integration to the gradient would allow to <br>
develop ODF import/export parallel to other filter. Is that correct?<br></blockquote><div><br></div><div>ODF and UNO model don't have to depend on each other because you can access the internal model in ODF filter too. <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Do you see a change to get such into LO7.6 (or maybe named LO8)? Or <br>
should we not even try to get integration of multi-color gradient and <br>
theme colors to LO7.6?<br></blockquote><div><br></div>I think we can add all the changes that are needed for theme colors and multi-color gradients into LO 7.6. Maybe some things won't be completed yet...<br></div><div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The current state of my start with import and export of multi-color <br>
gradient to ODF [3] does not consider "enhanced-color".<br></blockquote><div><br></div><div>That's fine. <br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
[2]<br>
<a href="https://www.w3.org/TR/css-color-4/#css-system-colors" rel="noreferrer" target="_blank">https://www.w3.org/TR/css-color-4/#css-system-colors</a><br>
[3]<br>
<a href="https://gerrit.libreoffice.org/c/core/+/150060" rel="noreferrer" target="_blank">https://gerrit.libreoffice.org/c/core/+/150060</a><br>
<br>
Kind regards,<br>
Regina<br></blockquote><div><br></div><div>Regards, <br></div><div>Tomaž Vajngerl <br></div></div></div>