<!DOCTYPE html>
<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hello,</p>
    <p>When investigating about tdf#159874 (<span id="summary_container"><span
          id="short_desc_nonedit_display">Inspection of 3D object in
          Development Tools crashes LibreOffice), I noticed there were
          TextureKind.idl and TextureKind2.idl</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">Taking a look at git history,
          I noticed first one was deprecated since
          4f9e6d84feb36ab3072dafbab0ba4ae46d264f9b</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">"#80594# added a new
          TextureKind2 enum because of missing value in TextureKind"</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">in 2000!</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">=> should we only use
          TextureKind2.idl now?</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">Also, in
          svx/source/sdr/primitive3d/sdrattributecreator3d.cxx, we can
          read this comment:<br>
          // TextureKind: 1 == Base3DTextureLuminance, 2 ==
          Base3DTextureIntensity, 3 == Base3DTextureColor<br>
          See
<a class="moz-txt-link-freetext" href="https://opengrok.libreoffice.org/xref/core/svx/source/sdr/primitive3d/sdrattributecreator3d.cxx?r=05416682#88">https://opengrok.libreoffice.org/xref/core/svx/source/sdr/primitive3d/sdrattributecreator3d.cxx?r=05416682#88</a><br>
          but TextureKind2.idl defines LUMINANCE, INTENSITY and COLOR
          with no number,<br>
          so I expect they take by default values 0, 1 and 2<br>
          See
<a class="moz-txt-link-freetext" href="https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/drawing/TextureKind2.idl?r=5687eba4">https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/drawing/TextureKind2.idl?r=5687eba4</a><br>
          <br>
          Same pb too with this line:<br>
          // TextureMode: 1 == Base3DTextureReplace, 2 ==
          Base3DTextureModulate, 3 == Base3DTextureBlend<br>
          TextureMode.idl just indicates: REPLACE, MODULATE and BLEND<br>
          <br>
          => should we change comments and related code?</span></span></p>
    <p><span id="summary_container"><span
          id="short_desc_nonedit_display">Julien<br>
        </span></span></p>
  </body>
</html>