<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello,</p>
<p>Unfortunately now it's flagging a lot of issues like</p>
<p>const SfxBoolItem* pStateItem = dynamic_cast<const
SfxBoolItem*>( pItem );<br>
assert(pStateItem); // SfxBoolItem expected<br>
if (pStateItem)<br>
↑ V547 Expression 'pStateItem' is always true.</p>
<p>which is not ideal either, so I updated the report again without
//V_ASSERT_CONTRACT</p>
<div class="moz-cite-prefix">On 25/11/24 10:09, Xisco Fauli wrote:<br>
</div>
<blockquote type="cite"
cite="mid:8b8352f0-03d4-4d52-ac97-525f12e298d3@libreoffice.org">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Hello,<br>
</p>
<div class="moz-cite-prefix">On 21/11/24 13:41, Caolán McNamara
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:97e7fafe357af88301b8dc653286c834591a4bdf.camel@collabora.com">
<pre class="moz-quote-pre" wrap=""><pre wrap=""
class="moz-quote-pre">On Thu, 2024-11-21 at 12:51 +0100, Xisco Fauli wrote:
</pre><blockquote type="cite" style="color: #007cff;"><pre wrap=""
class="moz-quote-pre">-> it can be fixed with
<a class="moz-txt-link-freetext"
href="https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7"
moz-do-not-send="true">https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7</a>
</pre></blockquote><pre wrap="" class="moz-quote-pre">Do I read it right, that it just has to see the comment somewhere, e.g.
if added to include/sal/config.h to treat all asserts like that ?</pre></pre>
</blockquote>
<p>Yes, that's one way. The other one is to pass a config file to
pvs-studio-analyzer with the -R flag. <a
class="moz-txt-link-freetext"
href="https://report.dev.libreoffice.org/"
moz-do-not-send="true">https://report.dev.libreoffice.org/</a>
has been updated using //V_ASSERT_CONTRACT<br>
</p>
<pre class="moz-signature" cols="72">--
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0</pre>
</body>
</html>