<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">A friendly ping to the mailing list. :-)<div><br></div><div>Chris<br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On 13 Feb 2025, at 9:41 pm, Chris Sherlock <chris.sherlock79@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Hi all, <div><br></div><div>Would someone be able to have a look at the following patches?</div><div><br></div><div><div style="display: block;"><div style="-webkit-user-select: all; -webkit-user-drag: element; display: inline-block;" class="apple-rich-link" draggable="true" role="link" data-url="https://gerrit.libreoffice.org/c/core/+/180822/"><a style="border-radius:10px;font-family:-apple-system, Helvetica, Arial, sans-serif;display:block;-webkit-user-select:none;width:300px;user-select:none;-webkit-user-modify:read-only;user-modify:read-only;overflow:hidden;text-decoration:none;" class="lp-rich-link" rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/180822/" dir="ltr" role="button" draggable="false" width="300"><table style="table-layout:fixed;border-collapse:collapse;width:300px;background-color:#E6A8A6;font-family:-apple-system, Helvetica, Arial, sans-serif;" class="lp-rich-link-emailBaseTable" cellpadding="0" cellspacing="0" border="0" width="300"><tbody><tr><td vertical-align="center"><table bgcolor="#E6A8A6" cellpadding="0" cellspacing="0" width="300" style="table-layout:fixed;font-family:-apple-system, Helvetica, Arial, sans-serif;background-color:rgba(230, 168, 166, 1);-apple-color-filter:initial;" class="lp-rich-link-captionBar"><tbody><tr><td style="padding:8px 0px 8px 0px;" class="lp-rich-link-captionBar-textStackItem"><div style="max-width:100%;margin:0px 16px 0px 16px;overflow:hidden;" class="lp-rich-link-captionBar-textStack"><div style="word-wrap:break-word;font-weight:400;font-size:11px;overflow:hidden;text-overflow:ellipsis;text-align:left;" class="lp-rich-link-captionBar-textStack-bottomCaption-leading"><a rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/180822/" style="text-decoration: none" draggable="false"><font color="#FFFFFF" style="color: rgba(255, 255, 255, 0.54902);">gerrit.libreoffice.org</font></a></div></div></td><td style="padding:6px 12px 6px 0px;" class="lp-rich-link-captionBar-rightIconItem" width="30"><a rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/180822/" draggable="false"><span id="cid:4AA17266-8637-4393-B2B4-8A2223E275B2"><favicon.ico></span></a></td></tr></tbody></table></td></tr></tbody></table></a></div></div></div><div><br></div><div><div style="display: block;"><div style="-webkit-user-select: all; -webkit-user-drag: element; display: inline-block;" class="apple-rich-link" draggable="true" role="link" data-url="https://gerrit.libreoffice.org/c/core/+/173743"><a style="border-radius:10px;font-family:-apple-system, Helvetica, Arial, sans-serif;display:block;-webkit-user-select:none;width:300px;user-select:none;-webkit-user-modify:read-only;user-modify:read-only;overflow:hidden;text-decoration:none;" class="lp-rich-link" rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/173743" dir="ltr" role="button" draggable="false" width="300"><table style="table-layout:fixed;border-collapse:collapse;width:300px;background-color:#E6A8A6;font-family:-apple-system, Helvetica, Arial, sans-serif;" class="lp-rich-link-emailBaseTable" cellpadding="0" cellspacing="0" border="0" width="300"><tbody><tr><td vertical-align="center"><table bgcolor="#E6A8A6" cellpadding="0" cellspacing="0" width="300" style="table-layout:fixed;font-family:-apple-system, Helvetica, Arial, sans-serif;background-color:rgba(230, 168, 166, 1);-apple-color-filter:initial;" class="lp-rich-link-captionBar"><tbody><tr><td style="padding:8px 0px 8px 0px;" class="lp-rich-link-captionBar-textStackItem"><div style="max-width:100%;margin:0px 16px 0px 16px;overflow:hidden;" class="lp-rich-link-captionBar-textStack"><div style="word-wrap:break-word;font-weight:400;font-size:11px;overflow:hidden;text-overflow:ellipsis;text-align:left;" class="lp-rich-link-captionBar-textStack-bottomCaption-leading"><a rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/173743" style="text-decoration: none" draggable="false"><font color="#FFFFFF" style="color: rgba(255, 255, 255, 0.54902);">gerrit.libreoffice.org</font></a></div></div></td><td style="padding:6px 12px 6px 0px;" class="lp-rich-link-captionBar-rightIconItem" width="30"><a rel="nofollow" href="https://gerrit.libreoffice.org/c/core/+/173743" draggable="false"><span id="cid:B8743754-397C-4652-B0A8-13B9CA0B052D"><favicon.ico></span></a></td></tr></tbody></table></td></tr></tbody></table></a></div></div><br></div><div>I created the BitmapFilter idea some time ago and these have been successfully adopted for a number of features in LibreOffice. Some wonderful filters have been created since then, but because I didn’t really document what I was doing some of the filters don’t really follow the pattern. The code is really excellent, so I accept it was my fault for not explaining myself better. </div><div><br></div><div>The first patch tries to remedy this by documenting the pattern. </div><div><br></div><div>The second patch brings the code into line with the command pattern in BitmapFilter. </div><div><br></div><div>If anyone would be willing to review this, it would be most appreciated :-)</div><div><br></div><div>Chris</div><div></div></div></div></blockquote></div><br></div></body></html>