[Libva] profile used in mplayer vaapi

[Xiang, Haihao]

On Tue, 2010-11-23 at 14:25 +0800, Yuan, Shengquan wrote:
> On Tue, Nov 23, 2010 at 2:21 PM, Xiang, Haihao <haihao.xiang at intel.com> wrote:
> > Hi,  Austin
> >
> >   VC1 has a profile flag in the sequence layer, however
> > VAPictureParameterBufferVC1 hasn't a member for this flag. The i965
> > video driver needs this flag, does the parameter 'profile' passed in
> > vaCreateConfig match the profile specified in the sequence layer?
> I don't think so, some players may always choose the highest profile
> for vaCreateConfig regardless of the indication in sequence layer.
> We may add something into VAPictureParameterBufferVC1 to resolve i965 issue

How about the following patch?

diff --git a/va/va.h b/va/va.h
index 7f24a85..b1e4136 100644
--- a/va/va.h
+++ b/va/va.h
@@ -857,6 +857,7 @@ typedef struct _VAPictureParameterBufferVC1
     /* sequence layer for AP or meta data for SP and MP */
     union {
         struct {
+            unsigned int profile	: 2; /* SEQUENCE_LAYER::PROFILE or The MSB of METADATA::PROFILE */
             unsigned int pulldown	: 1; /* SEQUENCE_LAYER::PULLDOWN */
             unsigned int interlace	: 1; /* SEQUENCE_LAYER::INTERLACE */
             unsigned int tfcntrflag	: 1; /* SEQUENCE_LAYER::TFCNTRFLAG */


> >
> > Thanks
> > Haihao
> >
> >
> >> Hi,
> >>
> >>   It seems mplayer_vaapi always uses the first profile in the supported
> >> list and passes it to vaapi driver via vaCreateConfig. Sometimes the
> >> vaapi driver needs to know which profile the decoded bitstream is in. Is
> >> there a way to pass the right profile to vaapi driver?
> >>
> >> Thanks
> >> Haihao
> >>