[Libva] [PATCH] Make VADriverContext.vtable a pointer
Gwenole Beauchesne
gbeauchesne at splitted-desktop.com
Thu Jan 27 05:54:29 PST 2011
Hi,
In order to avoid future breakage to drivers built against a specific
version of libva, I suggest we make the vtable a pointer. That structure
will be maintained (allocated/deallocated) by libva. Besides, this
structure can only grow in order to provide backwards compatibility.
e.g. the vaQuerySurfaceError() hook should have been placed at the end of
the VTable. Anyway, now that we bumped the VA-API version and new libva
versions will check for __vaDriverInit_0_32, we don't have to move it.
With simple changes similar to patches 302 & 303, the drivers I maintain
(vdpau-driver, xvba-driver) can expose both __vaDriverInit_0_31 and
__vaDriverInit_0_32, thus making it possible to remain compatible with any
libva version around.
Thanks,
Gwenole.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0301-Make-VADriverContext.vtable-a-pointer.patch
Type: text/x-diff
Size: 18929 bytes
Desc:
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110127/22e1f6f7/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0302-dummy_drv_video-make-VADriverContext.vtable-a-point.patch
Type: text/x-diff
Size: 6432 bytes
Desc:
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110127/22e1f6f7/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0303-i965_drv_video-make-VADriverContext.vtable-a-pointe.patch
Type: text/x-diff
Size: 6084 bytes
Desc:
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110127/22e1f6f7/attachment-0005.patch>
More information about the Libva
mailing list